diff --git a/devops/scripts/benchmarks/compare.py b/devops/scripts/benchmarks/compare.py index 483edd853b5b5..9c9159889a279 100644 --- a/devops/scripts/benchmarks/compare.py +++ b/devops/scripts/benchmarks/compare.py @@ -411,7 +411,7 @@ def print_regression(entry: dict, is_warning: bool = False): log_func(f"-- Delta: {entry['delta']}") log_func("") if args.produce_github_summary: - gh_summary.append(f"#### {entry['name']}:") + gh_summary.append(f"##### {entry['name']}:") gh_summary.append( f"- Historic {entry['avg_type']}: {entry['hist_avg']}" ) @@ -427,12 +427,16 @@ def print_regression(entry: dict, is_warning: bool = False): ) gh_summary.append("") + if args.produce_github_summary: + gh_summary.append("") + gh_summary.append("### Regressions and Improvements") + if improvements: log.info("#") log.info("# Improvements:") log.info("#") if args.produce_github_summary: - gh_summary.append(f"### Improvements") + gh_summary.append(f"#### Improvements") gh_summary.append( f"
{len(improvements)} improved tests:" ) @@ -444,12 +448,16 @@ def print_regression(entry: dict, is_warning: bool = False): gh_summary.append("") if regressions_ignored: log.info("#") - log.info("# Regressions (filtered out by --regression-filter):") + log.info( + f"# Regressions Ignored (filtered out by --regression-filter: {filter_type_capitalized})" + ) log.info("#") if args.produce_github_summary: - gh_summary.append(f"### Non-{filter_type_capitalized} Regressions") gh_summary.append( - f"
{len(regressions_ignored)} non-{args.regression_filter_type} regressions:" + f"#### Regressions Ignored (filtered out by --regression-filter: {filter_type_capitalized})" + ) + gh_summary.append( + f"
{len(regressions_ignored)} non-'{args.regression_filter_type}' regressions:" ) gh_summary.append("") for test in regressions_ignored: @@ -462,7 +470,7 @@ def print_regression(entry: dict, is_warning: bool = False): log.warning("# Regressions:") log.warning("#") if args.produce_github_summary: - gh_summary.append(f"### {filter_type_capitalized} Regressions") + gh_summary.append(f"#### {filter_type_capitalized} Regressions") gh_summary.append( f"{len(regressions_of_concern)} {args.regression_filter_type} regressions. These regressions warrant a CI failure:" ) @@ -480,8 +488,6 @@ def print_regression(entry: dict, is_warning: bool = False): log.info("No unexpected regressions found!") if args.produce_github_summary: - gh_summary.append("") - gh_summary.append("### Regressions") gh_summary.append("No unexpected regressions found!") with open(options.github_summary_regression_filename, "w") as f: f.write("\n".join(gh_summary))