[Decode][PDVT-SH] VP9 decode debug packet command counter support

* [Decode] VP9 decode debug packet command counter support
Added command counter register read functionality to VP9 decode debug packet. The command counter is now read unconditionally via MI_STORE_REGISTER_MEM and reported through status buffer. Added support for command counter override register via MI_LOAD_REGISTER_IMM when override value is set. Extended Completed() method to accept MFX status pointer for reading counter values. Updated user settings to report command counter and CRC values for debug purposes. Modified packet size calculation to account for new MI commands.

Author: pengwan1

media_softlet/agnostic/common/codec/hal/dec/vp9/packet/decode_vp9_debug_packet.cpp

@@ -77,13 +77,26 @@ MOS_STATUS Vp9DecodeDebugPkt::Execute(MOS_COMMAND_BUFFER& cmdBuffer, MediaStatus
 {
     DECODE_FUNC_CALL();
 
+    DECODE_CHK_NULL(statusReport);
+
     return MOS_STATUS_SUCCESS;
 }
 
-MOS_STATUS Vp9DecodeDebugPkt::Completed()
+MOS_STATUS Vp9DecodeDebugPkt::Completed(void *mfxStatus)
 {
     DECODE_FUNC_CALL();
 
+    DECODE_CHK_NULL(mfxStatus);
+
+    return MOS_STATUS_SUCCESS;
+}
+
+MOS_STATUS Vp9DecodeDebugPkt::AddCommandCounterCmds(MOS_COMMAND_BUFFER& cmdBuffer, MediaStatusReport *statusReport)
+{
+    DECODE_FUNC_CALL();
+
+    DECODE_CHK_NULL(statusReport);
+
     return MOS_STATUS_SUCCESS;
 }
 

media_softlet/agnostic/common/codec/hal/dec/vp9/packet/decode_vp9_debug_packet.h

@@ -96,10 +96,23 @@ class Vp9DecodeDebugPkt : public DecodeSubPacket
 
     //!
     //! \brief  Complete debug operations after decode
+    //! \param  [in] mfxStatus
+    //!         Pointer to MFX status
     //! \return MOS_STATUS
     //!         MOS_STATUS_SUCCESS if success, else fail reason
     //!
-    virtual MOS_STATUS Completed();
+    virtual MOS_STATUS Completed(void *mfxStatus);
+
+    //!
+    //! \brief  Add command counter commands
+    //! \param  [in] cmdBuffer
+    //!         Command buffer
+    //! \param  [in] statusReport
+    //!         Status report pointer
+    //! \return MOS_STATUS
+    //!         MOS_STATUS_SUCCESS if success, else fail reason
+    //!
+    virtual MOS_STATUS AddCommandCounterCmds(MOS_COMMAND_BUFFER& cmdBuffer, MediaStatusReport *statusReport);
 
 protected:
     std::shared_ptr<mhw::mi::Itf> m_miItf = nullptr;

media_softlet/agnostic/common/codec/hal/dec/vp9/packet/decode_vp9_packet.cpp

@@ -203,7 +203,7 @@ MOS_STATUS Vp9DecodePkt::Completed(void *mfxStatus, void *rcsStatus, void *statu
     // Call debug packet completion handling for HCP debug functionality
     if (m_debugPkt != nullptr)
     {
-        DECODE_CHK_STATUS(m_debugPkt->Completed());
+        DECODE_CHK_STATUS(m_debugPkt->Completed(mfxStatus));
     }
 #endif
 
@@ -295,6 +295,11 @@ MOS_STATUS Vp9DecodePkt::StartStatusReport(uint32_t srType, MOS_COMMAND_BUFFER*
         DECODE_CHK_NULL(m_phase);
         StoreEngineId(cmdBuffer, decode::DecodeStatusReportType::CsEngineIdOffset_0, m_phase->GetPipe());
     }
+    // Add command counter commands for debug
+    if (m_debugPkt != nullptr)
+    {
+        DECODE_CHK_STATUS(m_debugPkt->AddCommandCounterCmds(*cmdBuffer, m_statusReport));
+    }
 #endif
     return MOS_STATUS_SUCCESS;
 }

media_softlet/agnostic/common/codec/hal/dec/vp9/pipeline/decode_vp9_user_setting.cpp

@@ -93,6 +93,18 @@ MOS_STATUS Vp9Pipeline::InitUserSetting(MediaUserSettingSharedPtr userSettingPtr
         MediaUserSetting::Group::Sequence,
         int32_t(0),
         false);
+    DeclareUserSettingKeyForDebug(
+        userSettingPtr,
+        "VP9 Command Counter",
+        MediaUserSetting::Group::Sequence,
+        int32_t(0),
+        true);
+    DeclareUserSettingKeyForDebug(
+        userSettingPtr,
+        "VP9 CRC Value",
+        MediaUserSetting::Group::Sequence,
+        int32_t(0),
+        true);
 #endif
     return MOS_STATUS_SUCCESS;
 }