Skip to content

Commit b6bf10e

Browse files
wangyan-intelintel-mediadev
authored andcommitted
[Decode] Refactor histogram buffer allocation control flow
When meet repeat frame, avoid return nullptr directly to terminate decoding unexpected.
1 parent ee37000 commit b6bf10e

File tree

1 file changed

+6
-18
lines changed

1 file changed

+6
-18
lines changed

media_softlet/agnostic/common/codec/hal/dec/shared/features/decode_downsampling_feature.cpp

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -278,10 +278,8 @@ PMOS_BUFFER DecodeDownSamplingFeature::AllocateHistogramBuffer(uint8_t frameInde
278278
}
279279

280280
m_histogramBufferList[frameIndex] = histogramBuffer;
281-
282-
return m_histogramBufferList[frameIndex];
283281
}
284-
break;
282+
return m_histogramBufferList[frameIndex];
285283
case HistogramU:
286284
if (m_histogramBufferUList[frameIndex] == nullptr)
287285
{
@@ -300,10 +298,8 @@ PMOS_BUFFER DecodeDownSamplingFeature::AllocateHistogramBuffer(uint8_t frameInde
300298
}
301299

302300
m_histogramBufferUList[frameIndex] = histogramBufferU;
303-
304-
return m_histogramBufferUList[frameIndex];
305301
}
306-
break;
302+
return m_histogramBufferUList[frameIndex];
307303
case HistogramV:
308304
if (m_histogramBufferVList[frameIndex] == nullptr)
309305
{
@@ -322,10 +318,8 @@ PMOS_BUFFER DecodeDownSamplingFeature::AllocateHistogramBuffer(uint8_t frameInde
322318
}
323319

324320
m_histogramBufferVList[frameIndex] = histogramBufferV;
325-
326-
return m_histogramBufferVList[frameIndex];
327321
}
328-
break;
322+
return m_histogramBufferVList[frameIndex];
329323
case HistogramStatistics:
330324
if (m_histogramBufferStatisticsSummaryList[frameIndex] == nullptr)
331325
{
@@ -344,10 +338,8 @@ PMOS_BUFFER DecodeDownSamplingFeature::AllocateHistogramBuffer(uint8_t frameInde
344338
}
345339

346340
m_histogramBufferStatisticsSummaryList[frameIndex] = histogramBufferStatistics;
347-
348-
return m_histogramBufferStatisticsSummaryList[frameIndex];
349341
}
350-
break;
342+
return m_histogramBufferStatisticsSummaryList[frameIndex];
351343
case HistogramStreamIn:
352344
if (m_histogramBufferMetaDataStreamInList[frameIndex] == nullptr)
353345
{
@@ -366,10 +358,8 @@ PMOS_BUFFER DecodeDownSamplingFeature::AllocateHistogramBuffer(uint8_t frameInde
366358
}
367359

368360
m_histogramBufferMetaDataStreamInList[frameIndex] = histogramBufferStreamIn;
369-
370-
return m_histogramBufferMetaDataStreamInList[frameIndex];
371361
}
372-
break;
362+
return m_histogramBufferMetaDataStreamInList[frameIndex];
373363
case HistogramStreamOut:
374364
if (m_histogramBufferMetaDataStreamOutList[frameIndex] == nullptr)
375365
{
@@ -388,10 +378,8 @@ PMOS_BUFFER DecodeDownSamplingFeature::AllocateHistogramBuffer(uint8_t frameInde
388378
}
389379

390380
m_histogramBufferMetaDataStreamOutList[frameIndex] = histogramBufferStreamOut;
391-
392-
return m_histogramBufferMetaDataStreamOutList[frameIndex];
393381
}
394-
break;
382+
return m_histogramBufferMetaDataStreamOutList[frameIndex];
395383
default:
396384
DECODE_ASSERTMESSAGE("Failed to allocate hsitogram buffer due to invalid buffer type %d !", bufferType);
397385
break;

0 commit comments

Comments
 (0)