[Minor Fix] change default client api from vulkan to opencl (#568)

Author: Dewei-Wang-sh

include/imex/Transforms/Passes.td

@@ -38,7 +38,7 @@ def InsertGPUAllocs : Pass<"insert-gpu-allocs", "::mlir::func::FuncOp"> {
                            "::mlir::gpu::GPUDialect",
                            "::mlir::arith::ArithDialect"];
   let options = [
-    Option<"clientAPI", "client-api", "std::string", /*default=*/"\"vulkan\"",
+    Option<"clientAPI", "client-api", "std::string", /*default=*/"\"opencl\"",
            "The client API to use for inserting gpu allocs">
   ];
 }
@@ -47,7 +47,7 @@ def SetSPIRVCapabilities : Pass<"set-spirv-capabilities"> {
   let summary = "Sets Spirv capabilities";
   let constructor = "imex::createSetSPIRVCapabilitiesPass()";
   let options = [
-    Option<"clientAPI", "client-api", "std::string", /*default=*/"\"vulkan\"",
+    Option<"clientAPI", "client-api", "std::string", /*default=*/"\"opencl\"",
            "The client API to use for setting Spirv capabilities">
   ];
 }
@@ -58,7 +58,7 @@ def SetSPIRVAbiAttribute : Pass<"set-spirv-abi-attrs", "::mlir::gpu::GPUModuleOp
   let dependentDialects = ["::mlir::gpu::GPUDialect",
                            "::mlir::spirv::SPIRVDialect"];
   let options = [
-    Option<"clientAPI", "client-api", "std::string", /*default=*/"\"vulkan\"",
+    Option<"clientAPI", "client-api", "std::string", /*default=*/"\"opencl\"",
            "The client API to use for setting Spirv Abi attribute">
   ];
 }

lib/Transforms/SetSPIRVCapabilities.cpp

@@ -30,20 +30,16 @@ namespace {
 struct SetSPIRVCapabilitiesPass
     : public imex::impl::SetSPIRVCapabilitiesBase<SetSPIRVCapabilitiesPass> {
 public:
-  explicit SetSPIRVCapabilitiesPass() { m_clientAPI = "vulkan"; }
   explicit SetSPIRVCapabilitiesPass(const mlir::StringRef &clientAPI)
       : m_clientAPI(clientAPI) {}
 
   mlir::LogicalResult initializeOptions(mlir::StringRef options) override {
     if (failed(Pass::initializeOptions(options)))
       return mlir::failure();
 
-    if (clientAPI == "opencl") {
-      m_clientAPI = "opencl";
-    }
-
     if (clientAPI != "vulkan" && clientAPI != "opencl")
       return mlir::failure();
+    m_clientAPI = clientAPI;
 
     return mlir::success();
   }
@@ -111,7 +107,11 @@ struct SetSPIRVCapabilitiesPass
 } // namespace
 
 namespace imex {
+std::unique_ptr<mlir::Pass>
+createSetSPIRVCapabilitiesPass(mlir::StringRef api) {
+  return std::make_unique<SetSPIRVCapabilitiesPass>(api);
+}
 std::unique_ptr<mlir::Pass> createSetSPIRVCapabilitiesPass() {
-  return std::make_unique<SetSPIRVCapabilitiesPass>();
+  return createSetSPIRVCapabilitiesPass("opencl");
 }
 } // namespace imex

test/PlaidML/OpTest.Conv1D.mlir

@@ -54,7 +54,7 @@ module @conv_1d {
   func.func private @printMemrefF32(%ptr : tensor<*xf32>)
 }
 //      CHECK: Unranked Memref base@ = {{(0x)?[-9a-f]*}}
-// CHECK-NEXT: 76
+// CHECK-NEXT: [76
 // CHECK-NEXT: 99
 // CHECK-NEXT: 122
 // CHECK-NEXT: 145