Better reshape handling (#185)

Author: Hardcode84

numba_dpcomp/numba_dpcomp/mlir/numpy/funcs.py

@@ -583,7 +583,16 @@ def dtype_impl(builder, arg):
 
 @register_func("array.reshape")
 @register_func("numpy.reshape", numpy.reshape)
-def reshape_impl(builder, arg, new_shape):
+def reshape_impl(builder, arg, *new_shape):
+    if len(new_shape) == 1:
+        new_shape = new_shape[0]
+
+    # TODO: better check
+    if isinstance(new_shape, tuple):
+        for s in new_shape:
+            if isinstance(s, int) and s < 0:
+                return  # not supported for now
+
     return builder.reshape(arg, new_shape)
 
 

numba_dpcomp/numba_dpcomp/mlir/tests/test_numba_parfor.py

@@ -116,7 +116,6 @@ def _gen_tests():
         "test_tuple_concat",  # tuple concat
         "test_two_d_array_reduction_with_float_sizes",  # np.array
         "test_two_d_array_reduction_reuse",  # np.arange
-        "test_parfor_slice21",  # unsupported reshape
         "test_parfor_array_access_lower_slice",  # np.arange
         "test_size_assertion",  # AssertionError not raised
         "test_parfor_slice18",  # np.arange

numba_dpcomp/numba_dpcomp/mlir/tests/test_numpy.py

@@ -1004,7 +1004,9 @@ def py_func(a):
         "lambda a: a.reshape((a.size,))",
         "lambda a: a.reshape((a.size,1))",
         "lambda a: a.reshape((1, a.size))",
+        "lambda a: a.reshape(1, a.size)",
         "lambda a: a.reshape((1, a.size, 1))",
+        "lambda a: a.reshape(1, a.size, 1)",
         "lambda a: np.reshape(a, a.size)",
         "lambda a: np.reshape(a, (a.size,))",
         "lambda a: np.reshape(a, (a.size,1))",