fix compiler warnings

fix warnings -Wstrict-prototypes

fix warnings due to incorrect declaration classes

fix warnings due to c++11/17 standarts

fix compiler warnings in GPU case

fix build warnings with openMPI

fix cleanning IMB without GPU

Author: JuliaRS

ReadMe_IMB.txt

@@ -246,7 +246,8 @@ command-line parameters.
 -----------------------------------------
 Building Instructions for Linux* OS
 -----------------------------------------
-1) Set the CC variable to point to the appropriate compiler wrapper, mpiicc or mpicc.
+1) Set the CC and CXX variables to point to the appropriate compiler wrapper,
+   mpiicx or mpicc for C, mpiicpx or mpicxx for C++.
 2) Run one or more Makefile commands below:
 
    make clean - remove legacy binary object files and executable files

src_c/IMB_benchmark.h

@@ -49,6 +49,9 @@ For more documentation than found here, see
 
 #include "IMB_mem_info.h"
 
+#define IMB_INPUT_NAME_LEN 32
+#define IMB_INPUT_ARG_LEN 72
+
 /* Classification of benchmarks */
 
 typedef enum {

src_c/IMB_chk_diff.c

@@ -1310,13 +1310,13 @@ static long crc_32_tab[] = { /* CRC polynomial 0xedb88320 */
 
 
 
-long IMB_compute_crc (register char* buf, register size_t size) {
+long IMB_compute_crc (char* buf, size_t size) {
 /*
 
 In/out variables:
 
--buf                  (type register char*)
--size                 (type register int)
+-buf                  (type char*)
+-size                 (type int)
 
 Return value          (type long)
 

src_c/IMB_cuda.c

@@ -43,6 +43,9 @@ For more documentation than found here, see
 #ifdef GPU_ENABLE
 #include "IMB_cuda.h"
 
+static unsigned num_devices = 0;
+cudaStream_t cuda_stream;
+
 int cuda_initialize(char *dll_name)
 {
     cuda_init_functable_dll(dll_name);
@@ -86,7 +89,7 @@ void *cuda_alloc(size_t size, char *where, MEM_ALLOC_TYPE mem_alloc_type)
         }
         default:
         {
-            printf("Error: Unknown buf type\n");
+            printf("ERROR: Unknown buf type\n");
             exit(1);
         }
     }
@@ -122,7 +125,6 @@ void cuda_ass_buf(void *buf, int rank, size_t pos1, size_t pos2, int value)
     if (pos2 <= pos1)
         return;
 
-    static const int asize = (int)sizeof(assign_type);
     char *tmp_buf = malloc(pos2 + 1 - pos1);
     cuda_memcpy(tmp_buf, buf + pos1, pos2 - pos1);
     IMB_ass_buf(tmp_buf, rank, pos1, pos2, value);
@@ -153,7 +155,7 @@ void cuda_free(void **B, MEM_ALLOC_TYPE mem_alloc_type)
             }
             default:
             {
-                printf("Error: Unknown buf type\n");
+                printf("ERROR: Unknown buf type\n");
                 exit(1);
             }
         }

src_c/IMB_cuda.h

@@ -49,8 +49,7 @@ For more documentation than found here, see
 #include "IMB_declare.h"
 #include "IMB_benchmark.h"
 #include "IMB_cuda_api.h"
-
-static unsigned num_devices = 0;
+#include "IMB_prototypes.h"
 
 #define CUDA_CHKERR_EXPL_FINALLY(f, fin, a) { cudaError_t _cuda_chkerr_err; \
     if ((_cuda_chkerr_err=(f), (fin), _cuda_chkerr_err) != cudaSuccess) { \
@@ -75,7 +74,7 @@ static unsigned num_devices = 0;
 }
 #define C_CHKERR(f) C_CHKERR_EXPL(f, goto f_err)
 
-cudaStream_t cuda_stream;
+extern cudaStream_t cuda_stream;
 
 int cuda_initialize(char *dll_name);
 void *cuda_alloc(size_t size, char *where, MEM_ALLOC_TYPE mem_alloc_type);

src_c/IMB_cuda_api.c

@@ -72,7 +72,7 @@ void cuda_init_functable_dll(const char *dll_name)
 
     if (dl_error)
     {
-        printf("%s\n", dl_error);
+        fprintf(stderr, "%s\n", dl_error);
         exit(1);
     }
 
@@ -86,13 +86,13 @@ void cuda_init_functable_dll(const char *dll_name)
 
         if (dl_error)
         {
-            printf("%s\n", dl_error);
+            fprintf(stderr, "%s\n", dl_error);
             exit(1);
         }
 
         if (sym_ptr[i] == NULL)
         {
-            printf("Symbol %s is not available!\n", fn_names[i]);
+            fprintf(stderr, "Symbol %s is not available!\n", fn_names[i]);
             exit(1);
         }
     }

src_c/IMB_cuda_api.h

@@ -46,6 +46,8 @@ For more documentation than found here, see
 #include "cuda_runtime_api.h"
 #include "driver_types.h"
 #include <dlfcn.h>
+#include <stdio.h>
+#include <stdlib.h>
 
 /* *INDENT-OFF* */
 /* The current function names are from CUDA 12.0 */

src_c/IMB_gpu_common.c

@@ -43,6 +43,8 @@ For more documentation than found here, see
 #ifdef GPU_ENABLE
 #include "IMB_gpu_common.h"
 
+gpu_backend IMB_gpu_backend;
+
 void gpu_initialize()
 {
     char dll_name_cuda[] = "libcudart.so";

src_c/IMB_gpu_common.h

@@ -67,7 +67,7 @@ typedef struct gpu_backend {
     int   (*IMB_gpu_memcpy) (void*, const void*, size_t);
 } gpu_backend;
 
-gpu_backend IMB_gpu_backend;
+extern gpu_backend IMB_gpu_backend;
 
 void gpu_initialize();
 

src_c/IMB_init.c

@@ -459,7 +459,7 @@ int IMB_basic_input(struct comm_info* c_info, struct Bench** P_BList,
 
                 } else if (!strcmp((*argv)[iarg], "-iter_policy")) {
                     int ierr;
-                    char iter_policy[32];
+                    char iter_policy[IMB_INPUT_NAME_LEN];
                     if (iarg + 1 >= *argc) {
                         fprintf(stderr, "Missing argument after \"iter_policy\"\n");
                         ok = -1;
@@ -549,9 +549,9 @@ int IMB_basic_input(struct comm_info* c_info, struct Bench** P_BList,
                     iarg_msg = iarg + 1;
 
                     if (t) {
-                        char inp_line[72];
+                        char inp_line[IMB_INPUT_ARG_LEN];
 
-                        while (fgets(inp_line, 72, t)) {
+                        while (fgets(inp_line, IMB_INPUT_ARG_LEN, t)) {
                             if (inp_line[0] != '#' && strlen(inp_line) > 1)
                                 n_lens++;
                         }
@@ -574,17 +574,17 @@ int IMB_basic_input(struct comm_info* c_info, struct Bench** P_BList,
 
 
                     if (t) {
-                        char inp_line[72], nam[32];
-                        while (fgets(inp_line, 72, t)) {
+                        char inp_line[IMB_INPUT_ARG_LEN], name[IMB_INPUT_NAME_LEN];
+                        while (fgets(inp_line, IMB_INPUT_ARG_LEN, t)) {
                             if (inp_line[0] != '#' && strlen(inp_line) - 1) {
-                                sscanf(inp_line, "%32s", nam);
+                                sscanf(inp_line, "%31s[^\n]", name);
                                 if (n_cases >= 1000) {
                                     fprintf(unit, "Too many benchmark cases\n");
                                     fflush(stderr);
                                     ok = -1;
                                     break;
                                 }
-                                IMB_add_to_list_tail(nam, &Blist_head, &Blist_tail, &n_cases);
+                                IMB_add_to_list_tail(name, &Blist_head, &Blist_tail, &n_cases);
                             }
                         }
                         fclose(t);
@@ -631,8 +631,8 @@ int IMB_basic_input(struct comm_info* c_info, struct Bench** P_BList,
                         if ((min_log >= 0) &&
                             (max_log > 0) &&
                             (min_log < MAX_INT_LOG) &&
-                            (max_log<MAX_INT_LOG) &&
-                            (max_log>min_log)) {
+                            (max_log < MAX_INT_LOG) &&
+                            (max_log > min_log)) {
                             c_info->min_msg_log = min_log;
                             c_info->max_msg_log = max_log;
                         } else {
@@ -819,14 +819,14 @@ int IMB_basic_input(struct comm_info* c_info, struct Bench** P_BList,
                 c_info->n_lens = n_lens;
 
                 if (t && n_lens > 0) {
-                    char inp_line[72], S[72];
+                    char inp_line[IMB_INPUT_ARG_LEN], S[IMB_INPUT_ARG_LEN];
                     int sz, isz;
 
                     IMB_i_alloc(int, c_info->msglen, n_lens, "Basic_Input");
 
                     isz = -1;
 
-                    while (fgets(inp_line, 72, t)) {
+                    while (fgets(inp_line, IMB_INPUT_ARG_LEN, t)) {
                         S[0] = '\0';
                         if (inp_line[0] != '#' && strlen(inp_line) - 1) {
                             int ierr;