fix coverity issues

Author: JuliaRS

src_c/IMB_chk_diff.c

@@ -515,7 +515,7 @@ Output variables:
                 j2 = j_sample;
             }
 
-            MPI_ERRHAND(MPI_File_seek(restore, (MPI_Offset)(j1*Totalsize), MPI_SEEK_SET));
+            MPI_ERRHAND(MPI_File_seek(restore, (MPI_Offset)j1*(MPI_Offset)Totalsize, MPI_SEEK_SET));
 
             for (j = j1; j <= j2 && faultpos == CHK_NO_FAULT /*faultpos<0*/; j++) {
                 IMB_Assert(Totalsize <= INT_MAX);

src_c/IMB_read.c

@@ -346,7 +346,7 @@ Output variables:
             } /*if( pos == indv_block )*/
             else if (pos == explic) {
                 for (j = 0; j < j_sample; j++) {
-                    Offset = c_info->split.Offset + (MPI_Offset)(j*Totalsize);
+                    Offset = c_info->split.Offset + (MPI_Offset)j*(MPI_Offset)Totalsize;
 
                     MPI_ERRHAND(GEN_File_read_at(c_info->fh, Offset, c_info->r_buffer, Locsize, c_info->etype, &stat));
 
@@ -442,8 +442,7 @@ void IMB_iread_ij(struct comm_info* c_info, int size, POSITIONING pos,
                 }
             } else if (pos == explic) {
                 for (j = 0; j < i_sample*j_sample; j++) {
-
-                    Offset = c_info->split.Offset + (MPI_Offset)(j*Totalsize);
+                    Offset = c_info->split.Offset + (MPI_Offset)j*(MPI_Offset)Totalsize;
 
                     MPI_ERRHAND(MPI_File_read_at_all_begin(c_info->fh, Offset, c_info->r_buffer, Locsize, c_info->etype));
 
@@ -515,7 +514,7 @@ void IMB_iread_ij(struct comm_info* c_info, int size, POSITIONING pos,
                     }
                 } else if (pos == explic) {
                     for (j = 0; j < j_sample; j++) {
-                        Offset = c_info->split.Offset + (MPI_Offset)(j*Totalsize);
+                        Offset = c_info->split.Offset + (MPI_Offset)j*(MPI_Offset)Totalsize;
 
                         MPI_ERRHAND(MPI_File_iread_at(c_info->fh, Offset, c_info->r_buffer, Locsize, c_info->etype, &REQUESTS[j]));
 

src_c/IMB_write.c

@@ -306,7 +306,7 @@ void IMB_write_ij(struct comm_info* c_info, int size, POSITIONING pos,
                 }
             } else if (pos == explic) {
                 for (j = 0; j < j_sample; j++) {
-                    Offset = c_info->split.Offset + (MPI_Offset)((i + j)*Totalsize);
+                    Offset = c_info->split.Offset + (MPI_Offset)(i + j)*(MPI_Offset)Totalsize;
 
                     MPI_ERRHAND(GEN_File_write_at(c_info->fh, Offset, c_info->s_buffer, Locsize, c_info->etype, &stat));
 
@@ -406,7 +406,7 @@ void IMB_iwrite_ij(struct comm_info* c_info, int size, POSITIONING pos,
                 }
             } else if (pos == explic) {
                 for (j = 0; j < i_sample*j_sample; j++) {
-                    Offset = c_info->split.Offset + (MPI_Offset)(j*Totalsize);
+                    Offset = c_info->split.Offset + (MPI_Offset)j*(MPI_Offset)Totalsize;
 
                     MPI_ERRHAND(MPI_File_write_at_all_begin(c_info->fh, Offset, c_info->s_buffer, Locsize, c_info->etype));
 
@@ -471,7 +471,7 @@ void IMB_iwrite_ij(struct comm_info* c_info, int size, POSITIONING pos,
                 } else if (pos == explic) {
                     for (j = 0; j < j_sample; j++)
                     {
-                        Offset = c_info->split.Offset + (MPI_Offset)((i + j)*Totalsize);
+                        Offset = c_info->split.Offset + (MPI_Offset)(i + j)*(MPI_Offset)Totalsize;
 
                         MPI_ERRHAND(MPI_File_iwrite_at(c_info->fh, Offset, c_info->s_buffer, Locsize, c_info->etype, &REQUESTS[j]));
 

src_c/P2P/imb_p2p_stencil3d.c

@@ -59,12 +59,14 @@ void imb_p2p_stencil3d(void) {
         length_z++;
     }
     while ((length_x * length_y * length_z) > nranks) {
-        int n, lx, ly;
+        int lx, ly, n = 0;
         length_z--;
         while ((length_z > 1) && (nranks % length_z)) {
             length_z--;
         }
-        n = nranks / length_z;
+        if (length_z != 0) {
+            n = nranks / length_z;
+        }
         lx = 2;
         ly = 2;
         while ((lx * ly) < n) {