Skip to content

Add FramePack example #2341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Add FramePack example #2341

wants to merge 6 commits into from
+569 −1

Conversation

@mengniwang95
Copy link
Contributor

@mengniwang95 mengniwang95 commented Nov 21, 2025 •
edited by PRAgent4INC
Loading

User description

Type of Change

example

Description

depends on main branch of auto_round

PR Type

Enhancement

Description

  • Added FramePack example with benchmark script

  • Included README with setup instructions and usage examples

  • Enhanced script to handle multiple GPU configurations

Diagram Walkthrough

flowchart LR
  A["Add run_benchmark.sh"] -- "Handles parameters and runs benchmark" --> B["Add README.md"]
  B -- "Provides setup and usage instructions" --> C["Enhance script for multi-GPU"]
Loading

File Walkthrough
Relevant files
Enhancement
run_benchmark.sh
Add benchmark script                                                                         

examples/pytorch/diffusion_model/diffusers/framepack/run_benchmark.sh

  • Added script to initialize parameters and run benchmark
  • Handles different topologies and GPU configurations
 +128/-0 
Documentation
README.md
Add README for FramePack example                                                 

examples/pytorch/diffusion_model/diffusers/framepack/README.md

  • Added README with environment setup and usage examples
 +57/-0   

Mengni Wang and others added 2 commits November 18, 2025 03:47
draft
5dba7d4 
Signed-off-by: Mengni Wang <[email protected]>
@mengniwang95
fix bug and enhance script
bb1d465 
Signed-off-by: Mengni Wang <[email protected]>
@PRAgent4INC
Copy link
Collaborator

PRAgent4INC commented Nov 21, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Error Handling

The script does not handle cases where required parameters (e.g., topology, dataset_location) are not provided. It should include checks to ensure all necessary parameters are set before proceeding.

 
function init_params {
  for var in "$@"
  do
    case $var in
      --topology=*)
          topology=$(echo $var |cut -f2 -d=)
      ;;
      --dataset_location=*)
          dataset_location=$(echo $var |cut -f2 -d=)
      ;;
      --ratio=*)
          ratio=$(echo $var |cut -f2 -d=)
      ;;
      --input_model=*)
          input_model=$(echo $var |cut -f2 -d=)
      ;;
      --limit=*)
          limit=$(echo $var |cut -f2 -d=)
      ;;
      --output_video_path=*)
          output_video_path=$(echo $var |cut -f2 -d=)
      ;;
      --result_path=*)
          result_path=$(echo $var |cut -f2 -d=)
      ;;
      --dimension_list=*)
          dimension_list=$(echo $var |cut -f2 -d=)
      ;;
      *)
          echo "Error: No such parameter: ${var}"
          exit 1
      ;;
    esac
Variable Initialization

Variables like topology, dataset_location, etc., are used without being initialized. Ensure these variables are either initialized with default values or checked for existence before use.

 
function init_params {
  for var in "$@"
  do
    case $var in
      --topology=*)
          topology=$(echo $var |cut -f2 -d=)
      ;;
      --dataset_location=*)
          dataset_location=$(echo $var |cut -f2 -d=)
      ;;
      --ratio=*)
          ratio=$(echo $var |cut -f2 -d=)
      ;;
      --input_model=*)
          input_model=$(echo $var |cut -f2 -d=)
      ;;
      --limit=*)
          limit=$(echo $var |cut -f2 -d=)
      ;;
      --output_video_path=*)
          output_video_path=$(echo $var |cut -f2 -d=)
      ;;
      --result_path=*)
          result_path=$(echo $var |cut -f2 -d=)
      ;;
      --dimension_list=*)
          dimension_list=$(echo $var |cut -f2 -d=)
      ;;
      *)
          echo "Error: No such parameter: ${var}"
          exit 1
      ;;
    esac
Parallel Execution

The script runs multiple instances of main.py in parallel using &. Ensure that there are no race conditions or shared resources that could cause issues when running in parallel.

 
    for ((i=0; i<count; i++)); do
        export CUDA_VISIBLE_DEVICES=${gpu_ids[i]}
        python3 main.py \
            --output_video_path ${output_video_path} \
    	--dataset_location ${dataset_location} \
            --ratio ${ratio} \
            --limit ${limit} \
            --dimension_list ${dimensions[i]} \
            ${extra_cmd} &
        program_pid+=($!)
        echo "Start (PID: ${program_pid[-1]}, GPU: ${i})"
    done
    wait "${program_pid[@]}"
else

@PRAgent4INC
Copy link
Collaborator

PRAgent4INC commented Nov 21, 2025

Failed to generate code suggestions for PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Review effort 4/5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mengniwang95 @PRAgent4INC