specify compilation flags for each target that did not pass the binskim scan

ShaojieZhuIntel · ShaojieZhuIntel · commit 899b0769378b · 2025-02-21T09:04:59.000+08:00
Signed-off-by: Zhu, Shaojie &lt;shaojie.zhu@intel.com&gt;
diff --git a/llvm/lib/Analysis/CMakeLists.txt b/llvm/lib/Analysis/CMakeLists.txt
@@ -162,7 +162,7 @@ add_llvm_component_library(LLVMAnalysis
   TargetParser
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(LLVMAnalysis PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/llvm/lib/BinaryFormat/CMakeLists.txt b/llvm/lib/BinaryFormat/CMakeLists.txt
@@ -22,7 +22,7 @@ add_llvm_component_library(LLVMBinaryFormat
   TargetParser
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(LLVMBinaryFormat PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/llvm/lib/Bitcode/Reader/CMakeLists.txt b/llvm/lib/Bitcode/Reader/CMakeLists.txt
@@ -18,7 +18,7 @@ add_llvm_component_library(LLVMBitReader
   TargetParser
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(LLVMBitReader PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/llvm/lib/Frontend/Offloading/CMakeLists.txt b/llvm/lib/Frontend/Offloading/CMakeLists.txt
@@ -16,7 +16,7 @@ add_llvm_component_library(LLVMFrontendOffloading
   TargetParser
 )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(LLVMFrontendOffloading PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/llvm/lib/Frontend/OpenMP/CMakeLists.txt b/llvm/lib/Frontend/OpenMP/CMakeLists.txt
@@ -23,7 +23,7 @@ add_llvm_component_library(LLVMFrontendOpenMP
   FrontendOffloading
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(LLVMFrontendOpenMP PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/llvm/lib/IR/CMakeLists.txt b/llvm/lib/IR/CMakeLists.txt
@@ -88,7 +88,7 @@ add_llvm_component_library(LLVMCore
   TargetParser
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(LLVMCore PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/llvm/lib/ProfileData/CMakeLists.txt b/llvm/lib/ProfileData/CMakeLists.txt
@@ -29,7 +29,7 @@ add_llvm_component_library(LLVMProfileData
   TargetParser
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(LLVMProfileData PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/llvm/lib/Remarks/CMakeLists.txt b/llvm/lib/Remarks/CMakeLists.txt
@@ -22,7 +22,7 @@ add_llvm_component_library(LLVMRemarks
   intrinsics_gen
 )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(LLVMRemarks PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/llvm/lib/Support/CMakeLists.txt b/llvm/lib/Support/CMakeLists.txt
@@ -292,7 +292,7 @@ add_llvm_component_library(LLVMSupport
   Demangle
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
     target_compile_options(LLVMSupport PRIVATE
       /w34146 /w34244 /w34267
     )
diff --git a/llvm/lib/TargetParser/CMakeLists.txt b/llvm/lib/TargetParser/CMakeLists.txt
@@ -40,7 +40,7 @@ add_llvm_component_library(LLVMTargetParser
   RISCVTargetParserTableGen
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(LLVMTargetParser PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/llvm/lib/Transforms/Scalar/CMakeLists.txt b/llvm/lib/Transforms/Scalar/CMakeLists.txt
@@ -99,7 +99,7 @@ add_llvm_component_library(LLVMScalarOpts
   TransformUtils
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(LLVMScalarOpts PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/llvm/lib/Transforms/Utils/CMakeLists.txt b/llvm/lib/Transforms/Utils/CMakeLists.txt
@@ -100,7 +100,7 @@ add_llvm_component_library(LLVMTransformUtils
   TargetParser
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(LLVMTransformUtils PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/mlir/lib/Analysis/CMakeLists.txt b/mlir/lib/Analysis/CMakeLists.txt
@@ -57,7 +57,7 @@ add_mlir_library(MLIRAnalysis
   MLIRViewLikeInterface
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(MLIRAnalysis PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/mlir/lib/AsmParser/CMakeLists.txt b/mlir/lib/AsmParser/CMakeLists.txt
@@ -16,7 +16,7 @@ add_mlir_library(MLIRAsmParser
   MLIRIR
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(MLIRAsmParser PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/mlir/lib/Conversion/AffineToStandard/CMakeLists.txt b/mlir/lib/Conversion/AffineToStandard/CMakeLists.txt
@@ -22,7 +22,7 @@ add_mlir_conversion_library(MLIRAffineToStandard
   MLIRVectorDialect
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(MLIRAffineToStandard PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/mlir/lib/Conversion/ArithCommon/CMakeLists.txt b/mlir/lib/Conversion/ArithCommon/CMakeLists.txt
@@ -9,7 +9,7 @@ add_mlir_conversion_library(MLIRArithAttrToLLVMConversion
   MLIRLLVMDialect
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(MLIRArithAttrToLLVMConversion PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/mlir/lib/Conversion/ArithToLLVM/CMakeLists.txt b/mlir/lib/Conversion/ArithToLLVM/CMakeLists.txt
@@ -17,7 +17,7 @@ add_mlir_conversion_library(MLIRArithToLLVM
   MLIRLLVMDialect
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(MLIRArithToLLVM PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/mlir/lib/Conversion/ControlFlowToLLVM/CMakeLists.txt b/mlir/lib/Conversion/ControlFlowToLLVM/CMakeLists.txt
@@ -20,7 +20,7 @@ add_mlir_conversion_library(MLIRControlFlowToLLVM
   MLIRTransformUtils
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(MLIRControlFlowToLLVM PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/mlir/lib/Conversion/FuncToLLVM/CMakeLists.txt b/mlir/lib/Conversion/FuncToLLVM/CMakeLists.txt
@@ -22,7 +22,7 @@ add_mlir_conversion_library(MLIRFuncToLLVM
   MLIRTransformUtils
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(MLIRFuncToLLVM PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/mlir/lib/Dialect/Affine/Analysis/CMakeLists.txt b/mlir/lib/Dialect/Affine/Analysis/CMakeLists.txt
@@ -20,7 +20,7 @@ add_mlir_dialect_library(MLIRAffineAnalysis
   MLIRSCFDialect
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(MLIRAffineAnalysis PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/mlir/lib/Dialect/Affine/IR/CMakeLists.txt b/mlir/lib/Dialect/Affine/IR/CMakeLists.txt
@@ -24,7 +24,7 @@ add_mlir_dialect_library(MLIRAffineDialect
   MLIRValueBoundsOpInterface
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(MLIRAffineDialect PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/mlir/lib/Dialect/Affine/Utils/CMakeLists.txt b/mlir/lib/Dialect/Affine/Utils/CMakeLists.txt
@@ -18,7 +18,7 @@ add_mlir_dialect_library(MLIRAffineUtils
   MLIRViewLikeInterface
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(MLIRAffineUtils PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/mlir/lib/Dialect/Arith/IR/CMakeLists.txt b/mlir/lib/Dialect/Arith/IR/CMakeLists.txt
@@ -44,7 +44,7 @@ add_mlir_dialect_library(MLIRArithValueBoundsOpInterfaceImpl
   MLIRValueBoundsOpInterface
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(MLIRArithDialect PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/mlir/lib/Dialect/Arith/Utils/CMakeLists.txt b/mlir/lib/Dialect/Arith/Utils/CMakeLists.txt
@@ -11,7 +11,7 @@ add_mlir_dialect_library(MLIRArithUtils
   MLIRIR
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(MLIRArithUtils PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/mlir/lib/Dialect/Async/IR/CMakeLists.txt b/mlir/lib/Dialect/Async/IR/CMakeLists.txt
@@ -15,7 +15,7 @@ add_mlir_dialect_library(MLIRAsyncDialect
   MLIRIR
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(MLIRAsyncDialect PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/mlir/lib/Dialect/Bufferization/IR/CMakeLists.txt b/mlir/lib/Dialect/Bufferization/IR/CMakeLists.txt
@@ -29,7 +29,7 @@ add_mlir_dialect_library(MLIRBufferizationDialect
   MLIRBufferizationAllExtensions
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(MLIRBufferizationDialect PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/mlir/lib/Dialect/Bufferization/Transforms/CMakeLists.txt b/mlir/lib/Dialect/Bufferization/Transforms/CMakeLists.txt
@@ -42,7 +42,7 @@ add_mlir_dialect_library(MLIRBufferizationTransforms
   MLIRSupport
 )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(MLIRBufferizationTransforms PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/mlir/lib/Dialect/Complex/IR/CMakeLists.txt b/mlir/lib/Dialect/Complex/IR/CMakeLists.txt
@@ -17,7 +17,7 @@ add_mlir_dialect_library(MLIRComplexDialect
   MLIRIR
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(MLIRComplexDialect PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/mlir/lib/Dialect/ControlFlow/IR/CMakeLists.txt b/mlir/lib/Dialect/ControlFlow/IR/CMakeLists.txt
@@ -14,7 +14,7 @@ add_mlir_dialect_library(MLIRControlFlowDialect
   MLIRSideEffectInterfaces
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(MLIRControlFlowDialect PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/mlir/lib/Dialect/Func/IR/CMakeLists.txt b/mlir/lib/Dialect/Func/IR/CMakeLists.txt
@@ -16,7 +16,7 @@ add_mlir_dialect_library(MLIRFuncDialect
   MLIRSideEffectInterfaces
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(MLIRFuncDialect PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/mlir/lib/Dialect/Index/IR/CMakeLists.txt b/mlir/lib/Dialect/Index/IR/CMakeLists.txt
@@ -17,7 +17,7 @@ add_mlir_dialect_library(MLIRIndexDialect
   MLIRSideEffectInterfaces
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(MLIRIndexDialect PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/mlir/lib/Dialect/Utils/CMakeLists.txt b/mlir/lib/Dialect/Utils/CMakeLists.txt
@@ -9,7 +9,7 @@ add_mlir_library(MLIRDialectUtils
   MLIRIR
 )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(MLIRDialectUtils PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/mlir/lib/Interfaces/CMakeLists.txt b/mlir/lib/Interfaces/CMakeLists.txt
@@ -61,7 +61,7 @@ add_mlir_library(MLIRFunctionInterfaces
   MLIRIR
 )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(MLIRCallInterfaces PRIVATE
     /w34146 /w34244 /w34267
   )
diff --git a/mlir/lib/Target/LLVMIR/Dialect/Builtin/CMakeLists.txt b/mlir/lib/Target/LLVMIR/Dialect/Builtin/CMakeLists.txt
@@ -11,7 +11,7 @@ add_mlir_translation_library(MLIRBuiltinToLLVMIRTranslation
   MLIRTargetLLVMIRExport
   )
 
-if(MSVC and BUILD_COMPILER_FOR_DRIVER)
+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)
   target_compile_options(MLIRBuiltinToLLVMIRTranslation PRIVATE
     /w34146 /w34244 /w34267
   )

Original file line number	Diff line number	Diff line change
`@@ -162,7 +162,7 @@ add_llvm_component_library(LLVMAnalysis`
`162`	`162`	`TargetParser`
`163`	`163`	`)`
`164`	`164`
`165`		`-if(MSVC and BUILD_COMPILER_FOR_DRIVER)`
	`165`	`+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)`
`166`	`166`	`target_compile_options(LLVMAnalysis PRIVATE`
`167`	`167`	`/w34146 /w34244 /w34267`
`168`	`168`	`)`
Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ add_llvm_component_library(LLVMBinaryFormat`
`22`	`22`	`TargetParser`
`23`	`23`	`)`
`24`	`24`
`25`		`-if(MSVC and BUILD_COMPILER_FOR_DRIVER)`
	`25`	`+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)`
`26`	`26`	`target_compile_options(LLVMBinaryFormat PRIVATE`
`27`	`27`	`/w34146 /w34244 /w34267`
`28`	`28`	`)`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ add_llvm_component_library(LLVMBitReader`
`18`	`18`	`TargetParser`
`19`	`19`	`)`
`20`	`20`
`21`		`-if(MSVC and BUILD_COMPILER_FOR_DRIVER)`
	`21`	`+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)`
`22`	`22`	`target_compile_options(LLVMBitReader PRIVATE`
`23`	`23`	`/w34146 /w34244 /w34267`
`24`	`24`	`)`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ add_llvm_component_library(LLVMFrontendOffloading`
`16`	`16`	`TargetParser`
`17`	`17`	`)`
`18`	`18`
`19`		`-if(MSVC and BUILD_COMPILER_FOR_DRIVER)`
	`19`	`+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)`
`20`	`20`	`target_compile_options(LLVMFrontendOffloading PRIVATE`
`21`	`21`	`/w34146 /w34244 /w34267`
`22`	`22`	`)`
Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ add_llvm_component_library(LLVMFrontendOpenMP`
`23`	`23`	`FrontendOffloading`
`24`	`24`	`)`
`25`	`25`
`26`		`-if(MSVC and BUILD_COMPILER_FOR_DRIVER)`
	`26`	`+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)`
`27`	`27`	`target_compile_options(LLVMFrontendOpenMP PRIVATE`
`28`	`28`	`/w34146 /w34244 /w34267`
`29`	`29`	`)`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ add_llvm_component_library(LLVMCore`
`88`	`88`	`TargetParser`
`89`	`89`	`)`
`90`	`90`
`91`		`-if(MSVC and BUILD_COMPILER_FOR_DRIVER)`
	`91`	`+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)`
`92`	`92`	`target_compile_options(LLVMCore PRIVATE`
`93`	`93`	`/w34146 /w34244 /w34267`
`94`	`94`	`)`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ add_llvm_component_library(LLVMProfileData`
`29`	`29`	`TargetParser`
`30`	`30`	`)`
`31`	`31`
`32`		`-if(MSVC and BUILD_COMPILER_FOR_DRIVER)`
	`32`	`+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)`
`33`	`33`	`target_compile_options(LLVMProfileData PRIVATE`
`34`	`34`	`/w34146 /w34244 /w34267`
`35`	`35`	`)`
Original file line number	Diff line number	Diff line change
`@@ -292,7 +292,7 @@ add_llvm_component_library(LLVMSupport`
`292`	`292`	`Demangle`
`293`	`293`	`)`
`294`	`294`
`295`		`-if(MSVC and BUILD_COMPILER_FOR_DRIVER)`
	`295`	`+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)`
`296`	`296`	`target_compile_options(LLVMSupport PRIVATE`
`297`	`297`	`/w34146 /w34244 /w34267`
`298`	`298`	`)`
Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ add_llvm_component_library(LLVMTargetParser`
`40`	`40`	`RISCVTargetParserTableGen`
`41`	`41`	`)`
`42`	`42`
`43`		`-if(MSVC and BUILD_COMPILER_FOR_DRIVER)`
	`43`	`+if(MSVC AND BUILD_COMPILER_FOR_DRIVER)`
`44`	`44`	`target_compile_options(LLVMTargetParser PRIVATE`
`45`	`45`	`/w34146 /w34244 /w34267`
`46`	`46`	`)`