CVS-176574 : Fix memory leaks for protobuf & DataOps (#852)

* fix: fix mem leaks

* fix linux builds

Author: ankitm3k

cmake/onnxruntime_providers_openvino.cmake

@@ -33,6 +33,11 @@
   source_group(TREE ${ONNXRUNTIME_ROOT}/core FILES ${onnxruntime_providers_openvino_cc_srcs})
   onnxruntime_add_shared_library_module(onnxruntime_providers_openvino ${onnxruntime_providers_openvino_cc_srcs} "${ONNXRUNTIME_ROOT}/core/dll/onnxruntime.rc")
 
+  # Propagate leak check define if enabled at top level
+  if(onnxruntime_ENABLE_MEMLEAK_CHECKER)
+    target_compile_definitions(onnxruntime_providers_openvino PRIVATE ONNXRUNTIME_ENABLE_MEMLEAK_CHECK)
+  endif()
+
   onnxruntime_add_include_to_target(onnxruntime_providers_openvino onnxruntime_common onnx nlohmann_json::nlohmann_json)
   install(FILES ${PROJECT_SOURCE_DIR}/../include/onnxruntime/core/providers/openvino/openvino_provider_factory.h
     DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}/onnxruntime/)

onnxruntime/core/dll/dllmain.cc

@@ -30,6 +30,10 @@ BOOL APIENTRY DllMain(HMODULE /*hModule*/,
       if (lpvReserved != nullptr) {
         g_is_shutting_down = true;
         // do not do cleanup if process termination scenario
+#if defined(ONNXRUNTIME_ENABLE_MEMLEAK_CHECK)
+        // In leak-check builds we still want protobuf shutdown to avoid flagged leaks.
+        ::google::protobuf::ShutdownProtobufLibrary();
+#endif
       } else {
         // Cleanup protobuf library.
         // NOTE: it might be too early to do so, as all function local statics and global objects are not destroyed yet.

onnxruntime/core/providers/openvino/openvino_provider_dllmain.cc

@@ -0,0 +1,51 @@
+// Copyright (c) Intel Corporation.
+// Licensed under the MIT License.
+#ifdef _WIN32
+
+#include <Windows.h>
+#ifdef __GNUC__
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wignored-qualifiers"
+#pragma GCC diagnostic ignored "-Wunused-parameter"
+#else
+#endif
+#include <google/protobuf/message_lite.h>
+#ifdef __GNUC__
+#pragma GCC diagnostic pop
+#endif
+#include <atomic>
+
+// Reuse the global shutdown indicator (do NOT set it here; that is owned by the core DLL).
+extern std::atomic<bool> g_is_shutting_down;
+
+// NOTE:
+// This DllMain exists because the OpenVINO provider DLL statically links protobuf independently
+// of the core onnxruntime DLL. The core DLL's DllMain won't clean up this copy.
+// We perform protobuf shutdown on dynamic unload, and (optionally) during process termination
+// when memory leak checking is enabled.
+BOOL APIENTRY DllMain(HMODULE /*hModule*/,
+                      DWORD ul_reason_for_call,
+                      LPVOID lpvReserved) {
+  switch (ul_reason_for_call) {
+    case DLL_PROCESS_ATTACH:
+    case DLL_THREAD_ATTACH:
+    case DLL_THREAD_DETACH:
+      break;
+    case DLL_PROCESS_DETACH:
+      // Windows API doc says: "When handling DLL_PROCESS_DETACH, a DLL should free resources such as heap memory only if the DLL is being unloaded dynamically"
+      if (lpvReserved != nullptr) {
+        // Process termination. Normally skipped for speed/safety,
+        // but in leak-check builds we reclaim protobuf heap.
+#if defined(ONNXRUNTIME_ENABLE_MEMLEAK_CHECK)
+        ::google::protobuf::ShutdownProtobufLibrary();
+#endif
+      } else {
+        // Dynamic unload: safe to clean up.
+        ::google::protobuf::ShutdownProtobufLibrary();
+      }
+      break;
+  }
+  return TRUE;
+}
+
+#endif  // defined(_WIN32)

onnxruntime/core/providers/openvino/ov_versions/capability.cc

@@ -42,13 +42,13 @@ GetCapability::GetCapability(const EPCtxHandler& ep_ctx_handler,
   }
 
 #if OPENVINO_VERSION_MAJOR == 2025 && OPENVINO_VERSION_MINOR == 0
-  data_ops_ = new DataOps(graph_viewer_, V_2025_0, device_type_, npu_qdq_optimizer_enabled);
+  data_ops_ = std::make_unique<DataOps>(graph_viewer_, V_2025_0, device_type_, npu_qdq_optimizer_enabled);
 #elif OPENVINO_VERSION_MAJOR == 2025 && OPENVINO_VERSION_MINOR == 1
-  data_ops_ = new DataOps(graph_viewer_, V_2025_1, device_type_, npu_qdq_optimizer_enabled);
+  data_ops_ = std::make_unique<DataOps>(graph_viewer_, V_2025_1, device_type_, npu_qdq_optimizer_enabled);
 #elif OPENVINO_VERSION_MAJOR == 2025 && OPENVINO_VERSION_MINOR == 2
-  data_ops_ = new DataOps(graph_viewer_, V_2025_2, device_type_, npu_qdq_optimizer_enabled);
+  data_ops_ = std::make_unique<DataOps>(graph_viewer_, V_2025_2, device_type_, npu_qdq_optimizer_enabled);
 #else
-  data_ops_ = new DataOps(graph_viewer_, V_2025_2, device_type_, npu_qdq_optimizer_enabled);
+  data_ops_ = std::make_unique<DataOps>(graph_viewer_, V_2025_2, device_type_, npu_qdq_optimizer_enabled);
 #endif
 }
 

onnxruntime/core/providers/openvino/ov_versions/capability.h

@@ -16,7 +16,7 @@ class GetCapability {
   const EPCtxHandler& ep_ctx_handler_;
   const GraphViewer& graph_viewer_;
   std::string device_type_;
-  DataOps* data_ops_;
+  std::unique_ptr<DataOps> data_ops_;
   bool is_wholly_supported_graph_ = false;
   bool has_external_weights_ = false;