Don't set CMAKE_CXX_FLAGS PARENT_SCOPE in macro use_rtti (#444)

wenju-he · web-flow · commit bbf140262308 · 2023-05-22T16:58:03.000+08:00
cmake macro doesn't create new scope, so it is wrong to set PARENT_SCOPE
for CMAKE_CXX_FLAGS.
In addition, in out-of-tree build, the parent scope doesn't exist and
there is cmake warning.
diff --git a/cmake/modules/CMakeFunctions.cmake b/cmake/modules/CMakeFunctions.cmake
@@ -15,7 +15,6 @@ macro(use_rtti val)
             llvm_replace_compiler_option(CMAKE_CXX_FLAGS "-frtti" "-fno-rtti" )
         endif()
     endif()
-    set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}" PARENT_SCOPE )
 endmacro(use_rtti)
 
 #

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@ macro(use_rtti val)`
`15`	`15`	`llvm_replace_compiler_option(CMAKE_CXX_FLAGS "-frtti" "-fno-rtti" )`
`16`	`16`	`endif()`
`17`	`17`	`endif()`
`18`		`- set( CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS}" PARENT_SCOPE )`
`19`	`18`	`endmacro(use_rtti)`
`20`	`19`
`21`	`20`	`#`