handle a command buffer creation negative test case (#349)

bashbaug · web-flow · commit 6b7c49716554 · 2024-03-12T10:56:41.000-07:00
It is possible to pass in a nonzero number of queues but a null
queue array pointer.  This is an error, but we still shouldn't
crash.
diff --git a/intercept/src/dispatch.cpp b/intercept/src/dispatch.cpp
@@ -10351,7 +10351,7 @@ CL_API_ENTRY cl_command_buffer_khr CL_API_CALL clCreateCommandBufferKHR(
 
     if( pIntercept )
     {
-        cl_command_queue queue = num_queues ? queues[0] : NULL;
+        cl_command_queue queue = num_queues && queues ? queues[0] : NULL;
         const auto& dispatchX = pIntercept->dispatchX(queue);
         if( dispatchX.clCreateCommandBufferKHR )
         {
@@ -11263,7 +11263,7 @@ CL_API_ENTRY cl_command_buffer_khr CL_API_CALL clRemapCommandBufferKHR(
 
     if( pIntercept )
     {
-        cl_command_queue queue = num_queues ? queues[0] : NULL;
+        cl_command_queue queue = num_queues && queues ? queues[0] : NULL;
         const auto& dispatchX = pIntercept->dispatchX(queue);
         if( dispatchX.clRemapCommandBufferKHR )
         {

Original file line number	Diff line number	Diff line change
`@@ -10351,7 +10351,7 @@ CL_API_ENTRY cl_command_buffer_khr CL_API_CALL clCreateCommandBufferKHR(`
`10351`	`10351`
`10352`	`10352`	`if( pIntercept )`
`10353`	`10353`	`{`
`10354`		`- cl_command_queue queue = num_queues ? queues[0] : NULL;`
	`10354`	`+ cl_command_queue queue = num_queues && queues ? queues[0] : NULL;`
`10355`	`10355`	`const auto& dispatchX = pIntercept->dispatchX(queue);`
`10356`	`10356`	`if( dispatchX.clCreateCommandBufferKHR )`
`10357`	`10357`	`{`
`@@ -11263,7 +11263,7 @@ CL_API_ENTRY cl_command_buffer_khr CL_API_CALL clRemapCommandBufferKHR(`
`11263`	`11263`
`11264`	`11264`	`if( pIntercept )`
`11265`	`11265`	`{`
`11266`		`- cl_command_queue queue = num_queues ? queues[0] : NULL;`
	`11266`	`+ cl_command_queue queue = num_queues && queues ? queues[0] : NULL;`
`11267`	`11267`	`const auto& dispatchX = pIntercept->dispatchX(queue);`
`11268`	`11268`	`if( dispatchX.clRemapCommandBufferKHR )`
`11269`	`11269`	`{`