replaced os.system calls with subprocess to handle paths with spaces in them

Author: arisha07

choose_sd_model.py

@@ -4,12 +4,11 @@
 import platform
 
 if platform.system() == "Linux":
-	sd_python_path=os.path.join(".", "model_conv/bin/python3")
+    sd_python_path=os.path.join(".", "model_conv/bin/python3")
+    chose_model=os.path.join(os.path.dirname(__file__), "sd_model_conversion.py")
 else:
-	sd_python_path=r'model_conv\Scripts\python.exe'
-
-
-chose_model=os.path.join(os.path.dirname(__file__), "sd_model_conversion.py")  #r'openvino-ai-plugins-gimp\sd_model_conversion.py'
+    sd_python_path=r'model_conv\Scripts\python.exe'
+    chose_model=r'openvino-ai-plugins-gimp\sd_model_conversion.py'
 
 print("=========Chose SD-1.5 models to download and convert=========")
 print("1 - Square (512x512 output image) ")
@@ -26,20 +25,22 @@
 
     if choice=="6":
         for i in range(1,6):
-            command = sd_python_path + ' ' + chose_model + ' ' + str(i)
-            os.system(command)
+            
+            subprocess.call([sd_python_path, chose_model, str(i)])
+            
         break
     elif choice=="7":
         for i in range(1,4):
-            command = sd_python_path + ' ' + chose_model + ' ' + str(i)
-            os.system(command)
+       
+            subprocess.call([sd_python_path, chose_model, str(i)])
         break
     elif choice=="8":
         print("Exiting SD-1.5 Model setup.........")
         break
     elif choice in ["1","2","3","4","5"]:
-        command = sd_python_path + ' ' + chose_model + ' ' + choice
-        os.system(command)
+      
+        subprocess.call([sd_python_path, chose_model, choice])
+    
         break
 
     else:

sd_model_conversion.py

@@ -19,6 +19,7 @@
 from openvino.tools import mo
 from openvino.runtime import serialize
 import platform
+import subprocess
 
 
 #ov_version = sys.argv[1]
@@ -133,10 +134,10 @@ def convert_encoder_onnx(xtext_encoder: StableDiffusionPipeline, onnx_path:Path)
     try:
         encoder_model = mo.convert_model(TEXT_ENCODER_ONNX_PATH, compress_to_fp16=True)
         serialize(encoder_model, xml_path=os.path.join(weight_path, 'text_encoder.xml'))
-    #os.path.join(model, "vae_encoder.xml")
+  
     except:
-        os.system('%s --input_model %s --data_type=FP16 --output_dir %s' % (sd_mo_path,TEXT_ENCODER_ONNX_PATH,weight_path))
-   
+        subprocess.call([sd_mo_path, '--input_model', TEXT_ENCODER_ONNX_PATH, '--data_type=FP16', '--output_dir', weight_path])
+          
     print('Text Encoder successfully converted to IR')
 else:
     print(f"Text encoder will be loaded from {TEXT_ENCODER_OV_PATH}")
@@ -192,7 +193,8 @@ def convert_unet_onnx(unet:StableDiffusionPipeline, onnx_path:Path):
         unet_model = mo.convert_model(UNET_ONNX_PATH, compress_to_fp16=True)
         serialize(unet_model, xml_path=os.path.join(weight_path, 'unet.xml'))
     except:
-        os.system('%s --input_model %s --data_type=FP16 --output_dir %s' % (sd_mo_path, UNET_ONNX_PATH,weight_path))
+        subprocess.call([sd_mo_path, '--input_model', UNET_ONNX_PATH, '--data_type=FP16', '--output_dir', weight_path]) 
+       
 
     print('Unet successfully converted to IR')
 else:
@@ -237,12 +239,14 @@ def forward(self, image):
 
 if not VAE_ENCODER_OV_PATH.exists():
     convert_vae_encoder_onnx(vae, VAE_ENCODER_ONNX_PATH)
-    #os.system('mo --input_model %s --compress_to_fp16 --output_dir %s' % (VAE_ENCODER_ONNX_PATH,weight_path))
+  
     try:
         vae_encoder_model = mo.convert_model(VAE_ENCODER_ONNX_PATH, compress_to_fp16=True)
         serialize(vae_encoder_model, xml_path=os.path.join(weight_path, 'vae_encoder.xml'))
     except:
-        os.system('%s --input_model %s --data_type=FP16 --output_dir %s' % (sd_mo_path,VAE_ENCODER_ONNX_PATH,weight_path))
+        subprocess.call([sd_mo_path, '--input_model', VAE_ENCODER_ONNX_PATH, '--data_type=FP16', '--output_dir', weight_path])
+        
+        
     print('VAE encoder successfully converted to IR')
 else:
     print(f"VAE encoder will be loaded from {VAE_ENCODER_OV_PATH}")
@@ -284,12 +288,13 @@ def forward(self, latents):
 
 if not VAE_DECODER_OV_PATH.exists():
     convert_vae_decoder_onnx(vae, VAE_DECODER_ONNX_PATH)
-    #os.system('mo --input_model %s --compress_to_fp16 --output_dir %s' % (VAE_DECODER_ONNX_PATH,weight_path))
+ 
     try:
         vae_decoder_model = mo.convert_model(VAE_DECODER_ONNX_PATH, compress_to_fp16=True)
         serialize(vae_decoder_model, xml_path=os.path.join(weight_path, 'vae_decoder.xml'))
     except:
-        os.system('%s --input_model %s --data_type=FP16 --output_dir %s' % (sd_mo_path,VAE_DECODER_ONNX_PATH,weight_path))
+        subprocess.call([sd_mo_path, '--input_model', VAE_DECODER_ONNX_PATH, '--data_type=FP16', '--output_dir', weight_path])
+       
     print('VAE decoder successfully converted to IR')
 else:
     print(f"VAE decoder will be loaded from {VAE_DECODER_OV_PATH}")