Skip to content

Commit 18dbecd

Browse files
committed
pcm-daemon: drop partial write metric
1 parent 41b25be commit 18dbecd

File tree

3 files changed

+2
-17
lines changed

3 files changed

+2
-17
lines changed

src/client/main.cpp

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -255,13 +255,6 @@ int main(int argc, char *argv[])
255255
}
256256
std::cout << "\n";
257257

258-
printTitle("Mem Part. p/Sock.");
259-
for(PCMDaemon::uint32 i = 0; i < counters.system.numOfOnlineSockets; ++i)
260-
{
261-
std::cout << std::setprecision(coutPrecision) << counters.memory.sockets[i].partialWrite << " ";
262-
}
263-
std::cout << "\n";
264-
265258
printTitle("Mem Total p/Sock.");
266259
for(PCMDaemon::uint32 i = 0; i < counters.system.numOfOnlineSockets; ++i)
267260
{

src/daemon/common.h

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,13 @@
99
#include <stdint.h>
1010

1111
static const char DEFAULT_SHM_ID_LOCATION[] = "/tmp/opcm-daemon-shm-id";
12-
static const char VERSION[] = "1.0.5";
12+
static const char VERSION[] = "2.0.0";
1313

1414
#define MAX_CPU_CORES 4096
1515
#define MAX_SOCKETS 256
16-
#define MEMORY_MAX_IMC_CHANNELS (8)
16+
#define MEMORY_MAX_IMC_CHANNELS (12)
1717
#define MEMORY_READ 0
1818
#define MEMORY_WRITE 1
19-
#define MEMORY_PARTIAL 2
2019
#define QPI_MAX_LINKS (MAX_SOCKETS * 4)
2120

2221
#define VERSION_SIZE 12
@@ -122,7 +121,6 @@ namespace PCMDaemon {
122121
uint32 numOfChannels;
123122
float read;
124123
float write;
125-
float partialWrite;
126124
float total;
127125
double dramEnergy;
128126

@@ -131,7 +129,6 @@ namespace PCMDaemon {
131129
numOfChannels(0),
132130
read(-1.0),
133131
write(-1.0),
134-
partialWrite(-1.0),
135132
total(-1.0),
136133
dramEnergy(0.0) {}
137134
} ALIGN(ALIGNMENT);

src/daemon/daemon.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -554,13 +554,11 @@ namespace PCMDaemon {
554554
float iMC_Wr_socket_chan[MAX_SOCKETS][MEMORY_MAX_IMC_CHANNELS];
555555
float iMC_Rd_socket[MAX_SOCKETS];
556556
float iMC_Wr_socket[MAX_SOCKETS];
557-
uint64 partial_write[MAX_SOCKETS];
558557

559558
for(uint32 skt(0); skt < numSockets; ++skt)
560559
{
561560
iMC_Rd_socket[skt] = 0.0;
562561
iMC_Wr_socket[skt] = 0.0;
563-
partial_write[skt] = 0;
564562

565563
for(uint32 channel(0); channel < MEMORY_MAX_IMC_CHANNELS; ++channel)
566564
{
@@ -579,8 +577,6 @@ namespace PCMDaemon {
579577

580578
iMC_Rd_socket[skt] += iMC_Rd_socket_chan[skt][channel];
581579
iMC_Wr_socket[skt] += iMC_Wr_socket_chan[skt][channel];
582-
583-
partial_write[skt] += (uint64) (getMCCounter(channel,MEMORY_PARTIAL,serverUncoreCounterStatesBefore_[skt],serverUncoreCounterStatesAfter_[skt]) / (elapsedTime/1000.0));
584580
}
585581
}
586582

@@ -614,7 +610,6 @@ namespace PCMDaemon {
614610
memory.sockets[onlineSocketsI].numOfChannels = currentChannelI;
615611
memory.sockets[onlineSocketsI].read = iMC_Rd_socket[skt];
616612
memory.sockets[onlineSocketsI].write = iMC_Wr_socket[skt];
617-
memory.sockets[onlineSocketsI].partialWrite = partial_write[skt];
618613
memory.sockets[onlineSocketsI].total= iMC_Rd_socket[skt] + iMC_Wr_socket[skt];
619614
if(memory.dramEnergyMetricsAvailable)
620615
{

0 commit comments

Comments
 (0)