Fix dockerbuild by using separate Dockerfile + build in dockerignore

Author: ppalucki

.dockerignore

@@ -1 +1,2 @@
 /deployment
+/build

Dockerfile

@@ -2,12 +2,9 @@ FROM fedora:40@sha256:4e007f288dce23966216be81ef62ba05d139b9338f327c1d1c73b7167d
 
 RUN dnf -y install gcc-c++ git findutils make cmake
 COPY . /tmp/pcm
-# TEMPORARY change to be remove before merge, to not conflict with local builds + use cache
-# WARNING this approach requires me to build locally before docker build to get updated
-RUN --mount=type=cache,target=/tmp/pcm/build2 cd /tmp/pcm && cd build2 && cmake -D CMAKE_BUILD_TYPE=Debug .. && make -j pcm pcm-sensor-server
+RUN cd /tmp/pcm && mkdir build && cd build && cmake .. && make
 
 FROM fedora:40@sha256:4e007f288dce23966216be81ef62ba05d139b9338f327c1d1c73b7167dd47312
-RUN yum install -y strace gdb util-linux
 COPY --from=builder /tmp/pcm/build/bin/* /usr/local/bin/
 ENV PCM_NO_PERF=1
 

Dockerfile.debug

@@ -0,0 +1,7 @@
+FROM fedora:40@sha256:4e007f288dce23966216be81ef62ba05d139b9338f327c1d1c73b7167dd47312 as builder
+
+RUN dnf -y install gcc-c++ git findutils make cmake strace gdb util-linux
+COPY . /tmp/pcm
+RUN --mount=type=cache,target=/tmp/pcm/build cd /tmp/pcm/build && cmake -D CMAKE_BUILD_TYPE=Debug .. 
+RUN --mount=type=cache,target=/tmp/pcm/build cd /tmp/pcm/build && cmake --build . -t pcm -t pcm-sensor-server -t pcm-tpmi && cp -v /tmp/pcm/build/bin/pcm* /bin/
+#ENV PCM_NO_PERF=1

deployment/pcm/README.md

@@ -328,17 +328,17 @@ chmod +x ~/.docker/cli-plugins/docker-buildx
 docker buildx create --driver docker-container --name mydocker --use --bootstrap
 
 # or with single line (from deployment/pcm/ directory)
-# Build local image for tests/development + fix /pcm/resctrl mounting (assuming project was configured with cmake previously):
-# Note: Warning: we're using patched Dockerfile (TODO to be removed, because "build" directory conflits with existing root "build" directory and for caching ability)
-(cd ../.. ; (cd build ; make -j pcm pcm-sensor-server) ; docker build . -t localhost:5001/pcm-local && docker push localhost:5001/pcm-local)
+# Build local image for tests/development
+# Following Dockerfile contains source code of pcm and some debugging utils (like gdb,strace for further analysis)
+(cd ../.. ;  docker build . -f Dockerfile.debug -t localhost:5001/pcm-local && docker push localhost:5001/pcm-local)
 ```
 
 3) When deploying to kind cluster pcm use values to switch to local pcm-local image
 ```
 helm install pcm . -f values-local-image.yaml
 ```
 
-4) Replace pcm-sensor-server with pcm or sleep
+4) Replace pcm-sensor-server with pcm or sleep to be able to run `gdb` or `strace` for example
 ```
 helm upgrade --install pcm . --set debugPcm=true
 helm upgrade --install pcm . --set debugSleep=true