Skip to content

Commit fc07d1e

Browse files
opcmopcm
authored
Merge pull request #386 from kilobyte/typos
typo fixes
2 parents bb8d4eb + d233917 commit fc07d1e

21 files changed

+67
-67
lines changed

‎doc/MAC_HOWTO.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ Also PCM utilities are installing to /usr/local/sbin.
2626
Manual Install
2727
--------------
2828
Build steps are the same.
29-
For instal to do the following:
29+
To install do the following:
3030
1) load the driver by running src/MacMSRDriver/kextload.sh
3131
2) copy build/lib/libPcmMsr.dylib to a location on your path (auto-install uses /usr/lib)
3232
3) copy src/MacMSRDriver/MSRKernel.h to a location on your path (auto-install uses /usr/include)

‎doc/PCM_RAW_README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ Disclaimer: in contrast to other PCM utilities this one is for expert usage only
1111

1212
Currently supported PMUs: core, m3upi, upi(ll)/qpi(ll), imc, m2m, pcu, cha/cbo, iio, ubox
1313

14-
Recommended usage (as priviliged/root user):
14+
Recommended usage (as privileged/root user):
1515
1. Install VTune which also contains emon (emon/sep driver installation is not needed): [free download](https://software.intel.com/content/www/us/en/develop/tools/vtune-profiler.html)
1616
2. Run emon with `--dry-run -m` options to obtain raw PMU event encodings for event of interest. For example:
1717
```

‎doc/WINDOWS_HOWTO.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ Command-line utility:
1919

2020
For Windows 7 and Windows Server 2008 R2 the PCM utilities need to be run as administrator:
2121

22-
Alternatively you can achieve the same using the “Properties” Windows menu of the executable (“Privilege level” setting in the “Compatibilty” tab): Right mouse click -> Properties -> Compatibility -> Privilege level -> Set “Run this program as an administrator”.
22+
Alternatively you can achieve the same using the “Properties” Windows menu of the executable (“Privilege level” setting in the “Compatibility” tab): Right mouse click -> Properties -> Compatibility -> Privilege level -> Set “Run this program as an administrator”.
2323

2424
![Screenshot](run-as-administrator.png)
2525

‎examples/c_example.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ int main(int argc, const char *argv[])
104104
total += c[i];
105105
PCM.pcm_c_stop();
106106

107-
printf("[c_example] PCM measurment stopped, compute result %u\n", total);
107+
printf("[c_example] PCM measurement stopped, compute result %u\n", total);
108108

109109
lcore_id = pcm_getcpu();
110110
printf("C:%lu I:%lu, IPC:%3.2f\n",

‎src/cpuasynchcounter.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ Redistribution and use in source and binary forms, with or without modification,
1111
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
1212
*/
1313
//
14-
// asynchonous CPU conters
14+
// asynchronous CPU conters
1515
//
1616
// contact: Thomas Willhalm
1717

‎src/cpucounters.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ bool PCM::initWinRing0Lib()
130130

131131
class TemporalThreadAffinity // speedup trick for Linux, FreeBSD, DragonFlyBSD, Windows
132132
{
133-
TemporalThreadAffinity(); // forbiden
133+
TemporalThreadAffinity(); // forbidden
134134
#if defined(__FreeBSD__) || (defined(__DragonFly__) && __DragonFly_version >= 400707)
135135
cpu_set_t old_affinity;
136136
const bool restore;
@@ -3579,7 +3579,7 @@ uint32 PCM::checkCustomCoreProgramming(std::shared_ptr<SafeMsrHandle> msr)
35793579
const auto core = msr->getCoreId();
35803580
if (size_t(core) >= lastProgrammedCustomCounters.size() || canUsePerf)
35813581
{
3582-
// checking 'canUsePerf'because corruption detection curently works
3582+
// checking 'canUsePerf'because corruption detection currently works
35833583
// only if perf is not used, see https://github.com/opcm/pcm/issues/106
35843584
return 0;
35853585
}

‎src/cpucounters.h

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ class SystemRoot;
9494
A set of performance monitoring routines for recent Intel CPUs
9595
*/
9696

97-
struct PCM_API TopologyEntry // decribes a core
97+
struct PCM_API TopologyEntry // describes a core
9898
{
9999
int32 os_id;
100100
int32 thread_id;
@@ -1754,7 +1754,7 @@ class PCM_API PCM
17541754
};
17551755

17561756
//! \brief Program uncore PCIe monitoring event(s)
1757-
//! \param eventGroup - events to programm for the same run
1757+
//! \param eventGroup - events to program for the same run
17581758
void programPCIeEventGroup(eventGroup_t &eventGroup);
17591759
uint64 getPCIeCounterData(const uint32 socket_, const uint32 ctr_);
17601760

@@ -3097,7 +3097,7 @@ uint64 getInstructionsRetired(const CounterStateType & before, const CounterStat
30973097
return after.InstRetiredAny - before.InstRetiredAny;
30983098
}
30993099

3100-
/*! \brief Computes average number of retired instructions per time intervall
3100+
/*! \brief Computes average number of retired instructions per time interval
31013101
31023102
\param before CPU counter state before the experiment
31033103
\param after CPU counter state after the experiment
@@ -3193,7 +3193,7 @@ inline double getCoreIPC(const CounterStateType & before, const CounterStateType
31933193
return -1;
31943194
}
31953195

3196-
/*! \brief Computes average number of retired instructions per time intervall for the entire system combining instruction counts from logical cores to corresponding physical cores
3196+
/*! \brief Computes average number of retired instructions per time interval for the entire system combining instruction counts from logical cores to corresponding physical cores
31973197
31983198
Use this metric to evaluate cores utilization improvement between SMT(Hyperthreading) on and SMT off.
31993199
@@ -3702,7 +3702,7 @@ uint64 getIORequestBytesFromMC(const CounterStateType & before, const CounterSta
37023702
return 0ULL;
37033703
}
37043704

3705-
/*! \brief Returns the number of occured system management interrupts
3705+
/*! \brief Returns the number of occurred system management interrupts
37063706
37073707
\param before CPU counter state before the experiment
37083708
\param after CPU counter state after the experiment
@@ -3714,7 +3714,7 @@ uint64 getSMICount(const CounterStateType & before, const CounterStateType & aft
37143714
return after.SMICount - before.SMICount;
37153715
}
37163716

3717-
/*! \brief Returns the number of occured custom core events
3717+
/*! \brief Returns the number of occurred custom core events
37183718
37193719
Read number of events programmed with the \c CUSTOM_CORE_EVENTS
37203720
@@ -3794,7 +3794,7 @@ inline double getOutgoingQPILinkUtilization(uint32 socketNr, uint32 linkNr, cons
37943794
const uint64 bTSC = before.uncoreTSC;
37953795
const uint64 aTSC = after.uncoreTSC;
37963796
const double tsc = (double)((aTSC > bTSC) ? (aTSC - bTSC) : 0);
3797-
if (idle_flits >= tsc) return 0.; // prevent oveflows due to potential counter dissynchronization
3797+
if (idle_flits >= tsc) return 0.; // prevent overflows due to potential counter dissynchronization
37983798

37993799
return (1. - (idle_flits / tsc));
38003800
} else if (m->hasPCICFGUncore())
@@ -3808,7 +3808,7 @@ inline double getOutgoingQPILinkUtilization(uint32 socketNr, uint32 linkNr, cons
38083808
{
38093809
flits = flits/3.;
38103810
}
3811-
if (flits > max_flits) return 1.; // prevent oveflows due to potential counter dissynchronization
3811+
if (flits > max_flits) return 1.; // prevent overflows due to potential counter dissynchronization
38123812
return (flits / max_flits);
38133813
}
38143814

‎src/daemon/daemon.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -722,11 +722,11 @@ namespace PCMDaemon {
722722
{
723723
if(sharedPCMState_ != NULL)
724724
{
725-
//Detatch shared memory segment
725+
//Detach shared memory segment
726726
int success = shmdt(sharedPCMState_);
727727
if(success != 0)
728728
{
729-
std::cerr << "Failed to detatch the shared memory segment (errno=" << errno << ")\n";
729+
std::cerr << "Failed to detach the shared memory segment (errno=" << errno << ")\n";
730730
}
731731
else
732732
{

‎src/msr.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ namespace pcm {
4848

4949
extern HMODULE hOpenLibSys;
5050

51-
// here comes an implementatation for Windows
51+
// here comes an implementation for Windows
5252
MsrHandle::MsrHandle(uint32 cpu) : cpu_id(cpu)
5353
{
5454
hDriver = openMSRDriver();

‎src/pci.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -558,7 +558,7 @@ PciHandleM::~PciHandleM()
558558

559559
#endif // PCM_USE_PCI_MM_LINUX
560560

561-
// mmaped I/O version
561+
// mmapped I/O version
562562

563563
MCFGHeader PciHandleMM::mcfgHeader;
564564
std::vector<MCFGRecord> PciHandleMM::mcfgRecords;

0 commit comments

Comments
 (0)