Skip to content
This repository was archived by the owner on Oct 22, 2024. It is now read-only.

Commit 72af349

Browse files
committed
e2e: disable pod security checks
The pods that we deploy inside the test namespaces need privileges.
1 parent 2e46b90 commit 72af349

File tree

6 files changed

+30
-6
lines changed

6 files changed

+30
-6
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ require (
3232
k8s.io/kube-scheduler v0.25.0
3333
k8s.io/kubectl v1.25.0
3434
k8s.io/kubernetes v1.25.0
35+
k8s.io/pod-security-admission v0.0.0
3536
k8s.io/utils v0.0.0-20220812165043-ad590609e2e5
3637
sigs.k8s.io/controller-runtime v0.12.3
3738
sigs.k8s.io/sig-storage-lib-external-provisioner/v6 v6.2.0
@@ -111,7 +112,6 @@ require (
111112
k8s.io/kube-openapi v0.0.0-20220803162953-67bda5d908f1 // indirect
112113
k8s.io/kubelet v0.0.0 // indirect
113114
k8s.io/mount-utils v0.0.0 // indirect
114-
k8s.io/pod-security-admission v0.0.0 // indirect
115115
sigs.k8s.io/apiserver-network-proxy/konnectivity-client v0.0.32 // indirect
116116
sigs.k8s.io/json v0.0.0-20220713155537-f223a00ba0e2 // indirect
117117
sigs.k8s.io/structured-merge-diff/v4 v4.2.3 // indirect

test/e2e/storage/conversion.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ import (
3131
"k8s.io/client-go/kubernetes"
3232
"k8s.io/kubernetes/test/e2e/framework"
3333
e2epod "k8s.io/kubernetes/test/e2e/framework/pod"
34+
admissionapi "k8s.io/pod-security-admission/api"
3435

3536
api "github.com/intel/pmem-csi/pkg/apis/pmemcsi/v1beta1"
3637
"github.com/intel/pmem-csi/test/e2e/deploy"
@@ -48,6 +49,9 @@ var _ = deploy.DescribeForSome("raw-conversion", func(d *deploy.Deployment) bool
4849
}, func(d *deploy.Deployment) {
4950
f := framework.NewDefaultFramework("conversion")
5051

52+
// Several pods needs privileges.
53+
f.NamespacePodSecurityEnforceLevel = admissionapi.LevelPrivileged
54+
5155
It("works", func() {
5256
testRawNamespaceConversion(f, d.DriverName, d.Namespace)
5357
})

test/e2e/storage/dax/dax.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ import (
3131
e2epod "k8s.io/kubernetes/test/e2e/framework/pod"
3232
"k8s.io/kubernetes/test/e2e/framework/volume"
3333
storageframework "k8s.io/kubernetes/test/e2e/storage/framework"
34+
admissionapi "k8s.io/pod-security-admission/api"
3435

3536
api "github.com/intel/pmem-csi/pkg/apis/pmemcsi/v1beta1"
3637
"github.com/intel/pmem-csi/test/e2e/deploy"
@@ -92,6 +93,9 @@ func (p *daxTestSuite) DefineTests(driver storageframework.TestDriver, pattern s
9293

9394
f := framework.NewDefaultFramework("dax")
9495

96+
// Several pods needs privileges.
97+
f.NamespacePodSecurityEnforceLevel = admissionapi.LevelPrivileged
98+
9599
init := func() {
96100
l = local{}
97101

@@ -525,6 +529,10 @@ var _ = deploy.DescribeForSome("dax", func(d *deploy.Deployment) bool {
525529
}, func(d *deploy.Deployment) {
526530
var l local
527531
f := framework.NewDefaultFramework("dax")
532+
533+
// Several pods needs privileges.
534+
f.NamespacePodSecurityEnforceLevel = admissionapi.LevelPrivileged
535+
528536
init := func() {
529537
l = local{}
530538

test/e2e/storage/pmem_csi.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import (
1919
k8stypes "k8s.io/apimachinery/pkg/types"
2020
"k8s.io/kubernetes/test/e2e/framework"
2121
storageframework "k8s.io/kubernetes/test/e2e/storage/framework"
22+
admissionapi "k8s.io/pod-security-admission/api"
2223
runtime "sigs.k8s.io/controller-runtime/pkg/client"
2324

2425
"github.com/intel/pmem-csi/pkg/k8sutil"
@@ -52,6 +53,9 @@ var _ = deploy.DescribeForAll("Deployment", func(d *deploy.Deployment) {
5253
var _ = deploy.DescribeForAll("Deployment", func(d *deploy.Deployment) {
5354
f := framework.NewDefaultFramework("pmem-csi")
5455

56+
// Several pods needs privileges.
57+
f.NamespacePodSecurityEnforceLevel = admissionapi.LevelPrivileged
58+
5559
DefineLateBindingTests(d, f)
5660
DefineImmediateBindingTests(d, f)
5761
DefineKataTests(d)

test/e2e/tls/tls.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ import (
1919
"k8s.io/kubernetes/test/e2e/framework"
2020
e2epod "k8s.io/kubernetes/test/e2e/framework/pod"
2121
"k8s.io/kubernetes/test/e2e/framework/skipper"
22+
admissionapi "k8s.io/pod-security-admission/api"
2223

2324
"github.com/intel/pmem-csi/test/e2e/deploy"
2425
pmempod "github.com/intel/pmem-csi/test/e2e/pod"
@@ -31,6 +32,9 @@ import (
3132
var _ = deploy.DescribeForAll("TLS", func(d *deploy.Deployment) {
3233
f := framework.NewDefaultFramework("tls")
3334

35+
// Several pods needs privileges.
36+
f.NamespacePodSecurityEnforceLevel = admissionapi.LevelPrivileged
37+
3438
// All of the following pod names, namespaces and ports match
3539
// those in the current deployment files.
3640

test/e2e/versionskew/versionskew.go

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,20 +15,21 @@ import (
1515
"fmt"
1616
"strconv"
1717

18+
v1 "k8s.io/api/core/v1"
19+
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
20+
utilerrors "k8s.io/apimachinery/pkg/util/errors"
1821
"k8s.io/kubernetes/test/e2e/framework"
22+
e2edeployment "k8s.io/kubernetes/test/e2e/framework/deployment"
1923
"k8s.io/kubernetes/test/e2e/framework/skipper"
24+
e2evolume "k8s.io/kubernetes/test/e2e/framework/volume"
2025
storageframework "k8s.io/kubernetes/test/e2e/storage/framework"
26+
admissionapi "k8s.io/pod-security-admission/api"
2127

2228
"github.com/intel/pmem-csi/pkg/k8sutil"
2329
"github.com/intel/pmem-csi/pkg/version"
2430
"github.com/intel/pmem-csi/test/e2e/deploy"
2531
"github.com/intel/pmem-csi/test/e2e/driver"
2632
"github.com/intel/pmem-csi/test/e2e/storage/dax"
27-
v1 "k8s.io/api/core/v1"
28-
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
29-
utilerrors "k8s.io/apimachinery/pkg/util/errors"
30-
e2edeployment "k8s.io/kubernetes/test/e2e/framework/deployment"
31-
e2evolume "k8s.io/kubernetes/test/e2e/framework/volume"
3233

3334
. "github.com/onsi/ginkgo/v2"
3435
. "github.com/onsi/gomega"
@@ -155,6 +156,9 @@ func (p *skewTestSuite) DefineTests(driver storageframework.TestDriver, pattern
155156

156157
f := framework.NewDefaultFramework("skew")
157158

159+
// Several pods needs privileges.
160+
f.NamespacePodSecurityEnforceLevel = admissionapi.LevelPrivileged
161+
158162
// We rely here on the driver being named after a deployment
159163
// (see csi_volumes.go).
160164
d := deploy.MustParse(driver.GetDriverInfo().Name)

0 commit comments

Comments
 (0)