e2e: fix and extend CSI ephemeral volume sanity tests

The idempotency tests didn't really call the NodePublishVolume call
multiple time. Instead they stopped after the first successful call
due to a misplaced "break".

It's worth testing the default FS, ext4 and XFS separately because
code paths and idempotency handling might be different.

Author: pohly

test/e2e/storage/sanity.go

@@ -762,11 +762,11 @@ fi
 				v.remove(vol, volName)
 			})
 
-			Context("ephemeral volumes", func() {
-				doit := func(withFlag bool, repeatCalls int) {
+			Context("CSI ephemeral volumes", func() {
+				doit := func(withFlag bool, repeatCalls int, fsType string) {
 					targetPath := sc.TargetPath + "/ephemeral"
 					params := map[string]string{
-						"size": "1Mi",
+						"size": "100Mi",
 					}
 					if withFlag {
 						params["csi.storage.k8s.io/ephemeral"] = "true"
@@ -776,7 +776,9 @@ fi
 						VolumeContext: params,
 						VolumeCapability: &csi.VolumeCapability{
 							AccessType: &csi.VolumeCapability_Mount{
-								Mount: &csi.VolumeCapability_MountVolume{},
+								Mount: &csi.VolumeCapability_MountVolume{
+									FsType: fsType,
+								},
 							},
 							AccessMode: &csi.VolumeCapability_AccessMode{
 								Mode: csi.VolumeCapability_AccessMode_SINGLE_NODE_WRITER,
@@ -790,7 +792,6 @@ fi
 						_, err := nc.NodePublishVolume(ctx, &req)
 						if err == nil {
 							published = true
-							break
 						} else if failedPublish == nil {
 							failedPublish = fmt.Errorf("NodePublishVolume for ephemeral volume, attempt #%d: %v", i, err)
 						}
@@ -812,13 +813,21 @@ fi
 				}
 
 				doall := func(withFlag bool) {
-					It("work", func() {
-						doit(withFlag, 1)
-					})
+					for _, fs := range []string{"default", "ext4", "xfs"} {
+						fsType := fs
+						if fsType == "default" {
+							fsType = ""
+						}
+						Context(fs+" FS", func() {
+							It("work", func() {
+								doit(withFlag, 1, fsType)
+							})
 
-					It("are idempotent", func() {
-						doit(withFlag, 10)
-					})
+							It("are idempotent", func() {
+								doit(withFlag, 10, fsType)
+							})
+						})
+					}
 				}
 
 				Context("with csi.storage.k8s.io/ephemeral", func() {