Skip to content

Commit 224191e

Browse files
authored
[PTI-LIB] Remove check of command list type in callback test (#772)
* [PTI-LIB] Remove check of command list type in callback test Signed-off-by: Julia Fedorova <julia.fedorova@intel.com>
1 parent a4f2ce3 commit 224191e

File tree

1 file changed

+4
-14
lines changed

1 file changed

+4
-14
lines changed

sdk/test/callback_api_test.cc

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -725,18 +725,6 @@ class CallbackApiTest : public ::testing::TestWithParam<bool> {
725725
}
726726
}
727727

728-
static void CheckCommandListProperties(uint32_t cmd_list_properties) {
729-
if (command_list_immediate_) {
730-
EXPECT_TRUE(cmd_list_properties &
731-
pti_backend_command_list_type::PTI_BACKEND_COMMAND_LIST_TYPE_IMMEDIATE)
732-
<< "Expected IMMEDIATE command list property in ENTER callback";
733-
} else {
734-
EXPECT_FALSE(cmd_list_properties &
735-
pti_backend_command_list_type::PTI_BACKEND_COMMAND_LIST_TYPE_IMMEDIATE)
736-
<< "Did not expect IMMEDIATE command list property in ENTER callback";
737-
}
738-
}
739-
740728
// ============================================================================
741729
// Helper functions for TestCallback
742730
// ============================================================================
@@ -776,18 +764,20 @@ class CallbackApiTest : public ::testing::TestWithParam<bool> {
776764

777765
// Handles phase-specific logic for APPENDED domain
778766
static void HandlePhaseAppended(CallbackData* data, pti_callback_gpu_op_data* gpu_op_data) {
767+
// removed from below CheckCommandListProperties(gpu_op_data->_cmd_list_properties)
768+
// as immediate passed to queue creation per spec is just a hint
769+
// and runtime might decide to ignore it
770+
779771
if (gpu_op_data->_phase == PTI_CB_PHASE_API_ENTER) {
780772
data->enter_count++;
781773
data->appended_enter_count++;
782-
CheckCommandListProperties(gpu_op_data->_cmd_list_properties);
783774

784775
if (data->do_external_correlation_test) {
785776
PushOrPopExternalCorrelation(true, data, gpu_op_data->_correlation_id);
786777
}
787778
} else if (gpu_op_data->_phase == PTI_CB_PHASE_API_EXIT) {
788779
data->exit_count++;
789780
data->appended_exit_count++;
790-
CheckCommandListProperties(gpu_op_data->_cmd_list_properties);
791781

792782
if (data->do_external_correlation_test) {
793783
PushOrPopExternalCorrelation(false, data, gpu_op_data->_correlation_id);

0 commit comments

Comments
 (0)