Fix #51: correct OOM reporting in cbor_encoder_create_{array,map}

If the OOM condition happened on the encoding of the type and item
count, those two functions failed to return an error indicating that
there was an OOM. We had a unit test for this, but due to an off-by-one
error, we never actually tested the condition and just reported a false
positive.

Signed-off-by: Thiago Macieira <[email protected]>

Author: thiagomacieira

src/cborencoder.c

@@ -466,10 +466,7 @@ static CborError create_container(CborEncoder *encoder, CborEncoder *container,
     } else {
         err = encode_number_no_update(container, length, shiftedMajorType);
     }
-    if (err && !isOomError(err))
-        return err;
-
-    return CborNoError;
+    return err;
 }
 
 /**

tests/encoder/tst_encoder.cpp

@@ -599,7 +599,7 @@ void tst_Encoder::shortBuffer()
     QFETCH(QByteArray, output);
     QByteArray buffer(output.length(), Qt::Uninitialized);
 
-    for (int len = 0; len < output.length() - 1; ++len) {
+    for (int len = 0; len < output.length(); ++len) {
         CborEncoder encoder;
         cbor_encoder_init(&encoder, reinterpret_cast<quint8 *>(buffer.data()), len, 0);
         QCOMPARE(int(encodeVariant(&encoder, input)), int(CborErrorOutOfMemory));