[WA] Fix the lack of exceptions vector in getrf_batch #1916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Plan to remove this WA after upgrading to oneMKL 2025.3. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
CuiYifeng
force-pushed
the
yifeng/getrf_batch_wa
branch
from
15dac16 to
29605c0
Compare
chunhuanMeng
approved these changes
Aug 11, 2025
jianyizh
reviewed
Aug 11, 2025
jianyizh
approved these changes
Aug 11, 2025
CuiYifeng
force-pushed
the
yifeng/getrf_batch_wa
branch
from
29605c0 to
684d1cd
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a segmentation fault in the XPU MKL batch linear algebra implementation by addressing the lack of an exceptions vector in the batch_error exception handling. The fix implements a workaround to prevent crashes when accessing exception information during error handling.
- Added defensive check for empty exceptions vector before accessing it
- Enhanced error handling with proper TORCH_WARN logging instead of std::cout
- Modified info handling to use CPU tensors for thread safety
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
jianyizh
approved these changes
Aug 21, 2025
CuiYifeng
force-pushed
the
yifeng/getrf_batch_wa
branch
from
684d1cd to
6189925
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a work-around for the lack of exception vector within batch_error exception, otherwise segmentation fault would happen while accessing exceptions.