[wip] Symm support #1922
Open
[wip] Symm support #1922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request adds symmetric memory support for XPU devices. The implementation provides Level Zero-based memory allocation, inter-process communication (IPC), and symmetric memory management functionality.
- Adds Level Zero exception handling and dynamic library loading for XPU
- Implements XPU-specific symmetric memory allocator and memory management classes
- Provides IPC-based memory exchange mechanisms for multi-process communication
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
| ze_exception.hpp | Level Zero exception handling and dynamic library loading utilities |
| XPUSymmetricMemoryTypes.hpp | Type definitions for XPU symmetric memory implementation |
| XPUSymmetricMemoryUtils.hpp | Utility classes for symmetric memory operations and IPC communication |
| XPUSymmetricMemoryUtils.cpp | Implementation of IPC channels and memory mapping utilities |
| XPUSymmetricMemory.hpp | Main symmetric memory class declarations for XPU |
| XPUSymmetricMemory.cpp | Implementation of XPU symmetric memory allocator and management |
| ProcessGroupXCCL.cpp | Temporary workaround for barrier synchronization |
| IPCExchange.hpp | Inter-process communication utilities for memory handle exchange |
| world = tmp_world; | ||
| initialized = true; | ||
| } | ||
| void allreduce(sycl::queue& queue, void* inout_buffer, uint32_t size) {} |
There was a problem hiding this comment.
You don't need such APIs, please remove all allreduce APIs in this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.