Skip to content

Commit 093e028

Browse files
fix: tslint issues
1 parent fec12a7 commit 093e028

File tree

7 files changed

+17
-8
lines changed

7 files changed

+17
-8
lines changed

app/package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

app/src/integrations/git-platforms/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ export const makeInitialCommit = async (projectEntity: ProjectEntity) => {
4646
if (error.length !== 0) {
4747
throw new Error(error);
4848
}
49-
// TODO: uncomment this line
49+
5050
// delete the project from temp folder once it's pushed to git server.
51-
// fs.rmSync(createdProjectPath, {recursive: true});
51+
fs.rmSync(createdProjectPath, {recursive: true});
5252
};

app/src/models/project.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ export interface ProjectDTO {
3939
repositoryBranch: string;
4040
isRepositoryPublic: boolean;
4141
repositoryUrl: string;
42-
// TODO temporary made optional.
4342
metadata?: Metadata;
4443
ownerEmail: string;
4544
oldVersions?: OldVersion[];

app/tsconfig.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
// "sourceMap": true, /* Generates corresponding '.map' file. */
1919
// "outFile": "./", /* Concatenate and emit output to single file. */
2020
"outDir": "./dist",
21+
"skipLibCheck": true,
2122
/* Redirect output structure to the directory. */
2223
"rootDir": "./",
2324
/* Specify the root directory of input files. Use to control the output directory structure with --outDir. */

app/tslint.json

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,15 @@
33
"extends": [
44
"tslint:recommended"
55
],
6+
"compilerOptions": {
7+
"skipLibCheck": true
8+
},
9+
"exclude": [
10+
"node_modules/helmet",
11+
"./node_modules",
12+
"./node_modules/*",
13+
"./node_modules/helmet"
14+
],
615
"jsRules": {},
716
"rules": {
817
"no-console": [

core/internal/taroperations/utils.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ func listProjectFiles(projectDirectoryPath string) []string {
112112
return err
113113
}
114114
if !utils.IgnorablePaths(path) && !info.IsDir() {
115-
//TODO Needs to fix problem with below impl as it searches in current dir
115+
//TODO Needs to fix a problem with below impl as it searches in current dir
116116
//files = append(files, strings.Replace(path, projectDirectoryPath, "", -1))
117117
files = append(files, path)
118118
}

ui/tsconfig.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"lib": [
88
"dom",
99
"dom.iterable",
10-
"esnext"
10+
"es2020"
1111
],
1212
"strictPropertyInitialization": false,
1313
"allowJs": true,
@@ -17,7 +17,7 @@
1717
"strict": false,
1818
"forceConsistentCasingInFileNames": true,
1919
"noFallthroughCasesInSwitch": true,
20-
"module": "esnext",
20+
"module": "es2020",
2121
"moduleResolution": "node",
2222
"resolveJsonModule": true,
2323
"isolatedModules": true,

0 commit comments

Comments
 (0)