Skip to content

Commit d2a6e72

Browse files
fix: update call for users, projects and gitPlatforms. The values not passed in request were getting replaced by empty strings
1 parent 39e9851 commit d2a6e72

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

app/src/routes/gitPlatformOperations.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,9 @@ gitPlatformsOperationsRouter.put('/users/:email/gitPlatforms/:name', async (requ
103103
Logger.error(errorMessage);
104104
return response.status(400).json(getUpdateGitPlatformError(errorMessage));
105105
}
106-
gitPlatformDTO.updatedAt = new Date().toISOString();
107-
const isUpdated = await gitPlatformService.updateGitPlatform(ownerEmail, name, getGitPlatformEntity(gitPlatformDTO));
106+
gitPlatformEntity.updated_at = new Date().toISOString();
107+
gitPlatformEntity.personal_access_token = gitPlatformDTO.personalAccessToken;
108+
const isUpdated = await gitPlatformService.updateGitPlatform(ownerEmail, name, gitPlatformEntity);
108109
if (isUpdated) {
109110
const successMessage = `[${gitPlatformDTO.ownerEmail}] gitPlatform[${gitPlatformDTO.name}] updated.`;
110111
Logger.info(successMessage);

app/src/routes/projectsOperations.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,8 +109,10 @@ projectsOperationsRouter.put('/users/:email/projects/:id', requireEmailMiddlewar
109109
Logger.error(errorMessage);
110110
return response.status(400).json(getUpdateProjectError(errorMessage));
111111
}
112-
projectDTO.updatedAt = new Date().toISOString();
113-
const isUpdated = await projectService.updateProject(id, getProjectEntity(projectDTO));
112+
projectEntity.updated_at = new Date().toISOString();
113+
projectEntity.json = JSON.stringify(projectDTO.json);
114+
projectEntity.version = projectDTO.version;
115+
const isUpdated = await projectService.updateProject(id, projectEntity);
114116
if (isUpdated) {
115117
const successMessage = `[${projectDTO.ownerEmail}] project[${projectDTO.id}] updated.`;
116118
Logger.info(successMessage);

app/src/routes/usersOperations.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,11 @@ usersOperationsRouter.put('/:email', requireEmailMiddleware, async (request: Req
9292
Logger.error(errorMessage);
9393
return response.status(400).json(getUpdateUserError(errorMessage));
9494
}
95-
userDTO.updatedAt = new Date().toISOString();
96-
const isUpdated: boolean = await userService.updateUser(email, getUserEntity(userDTO));
95+
userEntity.updated_at = new Date().toISOString();
96+
userEntity.first_name = userDTO.firstName;
97+
userEntity.last_name = userDTO.lastName;
98+
userEntity.role = userDTO.role;
99+
const isUpdated: boolean = await userService.updateUser(email, userEntity);
97100
if (isUpdated) {
98101
const successMessage = `[${userDTO.email}] user updated.`;
99102
Logger.info(successMessage);

0 commit comments

Comments
 (0)