Skip to content

Commit 5af755c

Browse files
committed
pointer-nil-condition
1 parent cb94110 commit 5af755c

File tree

3 files changed

+34
-15
lines changed

3 files changed

+34
-15
lines changed

client/pkg/clickhouse/db_client.go

Lines changed: 31 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -607,19 +607,38 @@ func (c *DBClient) InsertTrivySbomMetrics(metrics model.Sbom) {
607607
tx, _ = c.conn.Begin()
608608
stmt, _ = tx.Prepare(InsertTrivySbom)
609609
)
610-
if _,err:= stmt.Exec(
611-
metrics.ID,
612-
result.CycloneDX.Metadata.Component.Name,
613-
result.CycloneDX.Metadata.Component.Version,
614-
result.CycloneDX.Metadata.Component.PackageURL,
615-
result.CycloneDX.Metadata.Component.MIMEType,
616-
result.CycloneDX.Metadata.Component.BOMRef,
617-
result.CycloneDX.SerialNumber,
618-
result.CycloneDX.Version,
619-
result.CycloneDX.BOMFormat,
620-
); err!=nil {
621-
log.Fatal(err)
610+
if result.CycloneDX != nil {
611+
if _,err:= stmt.Exec(
612+
metrics.ID,
613+
result.CycloneDX.Metadata.Component.Name,
614+
result.CycloneDX.Metadata.Component.PackageURL,
615+
result.CycloneDX.Metadata.Component.BOMRef,
616+
result.CycloneDX.SerialNumber,
617+
result.CycloneDX.Version,
618+
result.CycloneDX.BOMFormat,
619+
result.CycloneDX.Metadata.Component.Version,
620+
result.CycloneDX.Metadata.Component.MIMEType,
621+
); err!=nil {
622+
log.Fatal(err)
623+
}
624+
625+
}else {
626+
if _,err:= stmt.Exec(
627+
metrics.ID,
628+
"-",
629+
"-",
630+
"-",
631+
"-",
632+
"-",
633+
"-",
634+
"-",
635+
"-",
636+
); err!=nil {
637+
log.Fatal(err)
638+
}
639+
622640
}
641+
623642
if err:=tx.Commit();err!=nil {
624643
log.Fatal(err)
625644
}

client/pkg/clickhouse/statements.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -242,6 +242,6 @@ const InsertTrivyVul string = "INSERT INTO trivy_vul (id, cluster_name, namespac
242242
const InsertTrivyImage string = "INSERT INTO trivyimage (id, cluster_name, artifact_name, vul_id, vul_pkg_id, vul_pkg_name, vul_installed_version, vul_fixed_version, vul_title, vul_severity, vul_published_date, vul_last_modified_date) VALUES ( ?, ?,?, ?, ?, ?, ?, ?, ?, ?, ?, ?)"
243243
const InsertTrivyMisconfig string = "INSERT INTO trivy_misconfig (id, cluster_name, namespace, kind, name, misconfig_id, misconfig_avdid, misconfig_type, misconfig_title, misconfig_desc, misconfig_msg, misconfig_query, misconfig_resolution, misconfig_severity, misconfig_status, EventTime) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)"
244244
const InsertAzureContainerPushEvent DBStatement = "INSERT INTO azurecontainerpush (RegistryURL, RepositoryName, Tag, ImageName, Event, Size, SHAID, EventTime) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?)"
245-
const InsertTrivySbom string = "INSERT INTO trivysbom (id, image_name, image_version, package_url, mime_type, bom_ref, serial_number, version, bom_format) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)"
245+
const InsertTrivySbom string = "INSERT INTO trivysbom (id, image_name, package_url, bom_ref, serial_number, version, bom_format, component_version, component_mimetype) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)"
246246
const InsertQuayContainerPushEvent DBStatement = "INSERT INTO quaycontainerpush (name, repository, nameSpace, dockerURL, homePage, tag, Event, EventTime) VALUES (?, ?, ?, ?, ?, ?, ?, ?)"
247247
const InsertJfrogContainerPushEvent DBStatement = "INSERT INTO jfrogcontainerpush (Domain, EventType, RegistryURL, RepositoryName, SHAID, Size, ImageName, Tag, Event, EventTime) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)"

sql/0000015_trivysbom.up.sql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
11
CREATE TABLE IF NOT EXISTS trivysbom (
22
id UUID,
33
image_name String,
4-
image_version String,
54
package_url String,
6-
mime_type String,
75
bom_ref String,
86
serial_number String,
97
version INTEGER
108
bom_format String,
9+
component_version String,
10+
component_mime_type String,
1111
ExpiryDate DateTime DEFAULT now() + INTERVAL {{.TTLValue}} {{.TTLUnit}}
1212
) ENGINE = MergeTree()
1313
ORDER BY ExpiryDate

0 commit comments

Comments
 (0)