Skip to content

Commit 7c4497f

Browse files
committed
External Release v2024.11.04
- Fix issue with Clang on Windows for shared library builds. - Update minimum Python requirement from 3.8 to 3.9.
1 parent f32bc9b commit 7c4497f

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

mbuild/base.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -165,10 +165,10 @@ def check_python_version(maj,minor,fix=0):
165165

166166

167167
try:
168-
if check_python_version(3,8) == False:
169-
die("MBUILD error: Need Python version 3.8 or later.")
168+
if check_python_version(3,9) == False:
169+
die("MBUILD error: Need Python version 3.9 or later.")
170170
except:
171-
die("MBUILD error: Need Python version 3.8 or later.")
171+
die("MBUILD error: Need Python version 3.9 or later.")
172172

173173
import platform
174174
_on_mac = False

mbuild/build_env.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ def set_env_gnu(env):
201201
env['LIBOUT'] = ' ' # nothing when using gar/ar
202202
env['LINKOUT'] = '-o '
203203
env['EXEOUT'] = '-o '
204-
if env.on_mac():
204+
if env.on_mac() or env.on_windows():
205205
env['DLLOPT'] = '-shared' # '-dynamiclib'
206206
else:
207207
env['DLLOPT'] = '-shared -Wl,-soname,%(SOLIBNAME)s'

mbuild/env.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -452,8 +452,8 @@ def __init__(self, init_verbose=1, default_knobs=True):
452452
distro = ''
453453
distro_ver = ''
454454
if not self.on_mac() and not self.on_windows():
455-
if util.check_python_version(3,8):
456-
# With python 3.8 one needs to install the python "distro"
455+
if util.check_python_version(3,9):
456+
# With python 3.9 one needs to install the python "distro"
457457
# package to obtain the linux distro information. I do not
458458
# want to require users to install a non-default package
459459
# so we'll have to live without the distro information.

0 commit comments

Comments
 (0)