refactor: make get_role more consistent (#865)

* ADMIN/revert: remove unwanted file.

This file was actually cloned outside of the client directory in a PR that had not appropriately adjusted to the new architectural layout of the library.

* chore: Update requirements.txt

* chore: Version bump.

* chore/ADMIN: force version onto old pypi

This is an executive decision made between Delta and I. We will be forcing a version 4.0 push onto our old branch to help transition old users using v3 to our new project. This does not necessarily mean this branch will now be receiving updates along with the rest. The goal is to make our current branch used as much as possible.

* chore/ADMIN: fix content type

* fix/ADMIN: correct improper description

* revert/ADMIN: change back to original

* Update guild.py

* ci: correct from checks.

Co-authored-by: fl0w <[email protected]>
Co-authored-by: DeltaX <[email protected]>
Co-authored-by: Sofia <[email protected]>
Co-authored-by: James Walston <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Author: 4 people

interactions/api/models/guild.py

@@ -1645,14 +1645,19 @@ async def get_role(
         :rtype: Role
         """
 
+        for role in self.roles:
+            if int(role.id) == role_id:
+                return role
         if not self._client:
             raise LibraryException(code=13)
         roles = await self._client.get_all_roles(guild_id=int(self.id))
-        for i in roles:
-            if int(i["id"]) == role_id:
-                role = Role(**i)
-                break
-        return role
+        self.roles = [Role(**_) for _ in roles]
+        for role in self.roles:
+            if int(role.id) == role_id:
+                return role
+        raise LibraryException(
+            message="The role you looked for was not found!", code=0, severity=30
+        )
 
     async def modify_role_position(
         self,