Skip to content

Commit 5b516ae

Browse files
VoloVolo
authored andcommitted
Remove unnecessary field query from conversations.list params
1 parent c7bc99d commit 5b516ae

File tree

3 files changed

+13
-21
lines changed

3 files changed

+13
-21
lines changed

README.md

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -727,12 +727,10 @@ const response = await client.conversations.search({
727727

728728
```typescript
729729
const response = await client.conversations.list({
730-
query: {
731-
order: Order.DESC,
732-
sort: SortBy.UpdatedAt,
733-
page: 1,
734-
perPage: 10,
735-
},
730+
order: Order.DESC,
731+
sort: SortBy.UpdatedAt,
732+
page: 1,
733+
perPage: 10,
736734
});
737735
```
738736

lib/conversation.ts

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -257,9 +257,7 @@ export default class Conversation {
257257
data,
258258
});
259259
}
260-
list({
261-
query: { order, sort, page, perPage: per_page },
262-
}: ListConversationData) {
260+
list({ order, sort, page, perPage: per_page }: ListConversationData) {
263261
const params = { order, sort, page, per_page };
264262

265263
return this.client.get<ListConversationResponse>({
@@ -521,12 +519,10 @@ export enum SortBy {
521519
}
522520

523521
interface ListConversationData {
524-
query: {
525-
order: Order;
526-
sort: SortBy;
527-
page?: number;
528-
perPage?: number;
529-
};
522+
order?: Order;
523+
sort?: SortBy;
524+
page?: number;
525+
perPage?: number;
530526
}
531527

532528
type ListConversationResponse = Paginated<ConversationObjectWithoutParts>;

test/unit/conversation.test.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -557,12 +557,10 @@ describe('conversations', () => {
557557
});
558558

559559
const response = await client.conversations.list({
560-
query: {
561-
order: Order.DESC,
562-
sort: SortBy.UpdatedAt,
563-
page: 1,
564-
perPage: 10,
565-
},
560+
order: Order.DESC,
561+
sort: SortBy.UpdatedAt,
562+
page: 1,
563+
perPage: 10,
566564
});
567565

568566
assert.deepStrictEqual(expectedReply, response);

0 commit comments

Comments
 (0)