Merge pull request #305 from intercom/issue/296/invalid-types-for-search-conversations

Issue/296/invalid types for search conversations

Author: hypeofpipe

lib/common/common.types.ts

@@ -8,9 +8,8 @@ export enum Role {
     LEAD = 'lead',
 }
 
-export type Paginated<T> = {
+export type PaginatedBase = {
     type: string;
-    data: T[];
     pages: {
         type: 'pages';
         next?: {
@@ -24,6 +23,10 @@ export type Paginated<T> = {
     total_count: number;
 };
 
+export type Paginated<T> = PaginatedBase & {
+    data: T[];
+};
+
 export enum Operators {
     AND = 'AND',
     OR = 'OR',
@@ -42,12 +45,18 @@ export enum Operators {
 interface FlatQuery {
     field: string;
     operator: Operators;
-    value: string | number | null;
+    value: string | number | string[] | number[] | null;
 }
 
 interface NestedQueries {
     operator: Operators;
-    value: Array<FlatQuery | NestedQueries> | string | number | null;
+    value:
+        | Array<FlatQuery | NestedQueries>
+        | string
+        | number
+        | string[]
+        | number[]
+        | null;
 }
 
 export interface GenericSearchFilters {

lib/conversation.ts

@@ -4,6 +4,7 @@ import {
     StringifiedTimestamp,
     GenericSearchFilters,
     Order,
+    PaginatedBase,
 } from './common/common.types';
 import {
     ContactType,
@@ -509,7 +510,9 @@ interface SearchConversationRequest {
         Partial<SearchConversationOrder>;
 }
 
-type SearchConversationResponse = Paginated<ConversationObject>;
+type SearchConversationResponse = PaginatedBase & {
+    conversations: ConversationObject[];
+};
 //
 export enum SortBy {
     CreatedAt = 'created_at',

package.json

@@ -1,6 +1,6 @@
 {
     "name": "intercom-client",
-    "version": "3.1.0",
+    "version": "3.1.1",
     "description": "Official Node bindings to the Intercom API",
     "homepage": "https://github.com/intercom/intercom-node",
     "bugs:": "https://github.com/intercom/intercom-node/issues",