Merge pull request #94 from intercom/jo/spec-server-error

add test for server exceptions

Author: josler

src/Intercom/Exception/IntercomException.php

@@ -21,9 +21,18 @@ class IntercomException extends BadResponseException
      */
     public static function factory(RequestInterface $request, Response $response)
     {
-        if (!static::isValidIntercomError($response->json())) {
-            $label = 'Unsuccessful response';
-            $class = __CLASS__;
+        $response_json = $response->json();
+        $intercom_unavailable_error = NULL;
+
+        if (!static::isValidIntercomError($response_json)) {
+            if ($response->isServerError()) {
+                $label = 'Server error response';
+                $class = __NAMESPACE__ . '\\ServerErrorResponseException';
+                $intercom_unavailable_error = 'Service Unavailable: Back-end server is at capacity';
+            } else {
+                $label = 'Unsuccessful response';
+                $class = __CLASS__;
+            }
         } elseif ($response->isClientError()) {
             $label = 'Client error response';
             $class = __NAMESPACE__ . '\\ClientErrorResponseException';
@@ -49,8 +58,12 @@ public static function factory(RequestInterface $request, Response $response)
         $e->setRequest($request);
 
         // Sets the errors if the error response is the standard Intercom error type
-        if (static::isValidIntercomError($response->json())) {
-            $e->setErrors($response->json()['errors']);
+        if (static::isValidIntercomError($response_json)) {
+            $e->setErrors($response_json['errors']);
+        } elseif($intercom_unavailable_error != NULL) {
+            $e ->setErrors([array(
+              'code' => 'service_unavailable',
+              "message" => $intercom_unavailable_error)]);
         }
 
         return $e;

tests/Intercom/Exception/IntercomExceptionTest.php

@@ -18,4 +18,33 @@ public function test404Exception()
             $this->assertEquals('No such user with id[123456]', $errors[0]['message'] );
         }
     }
-}
+
+    public function test503Exception()
+    {
+        try {
+            $this->setMockResponse($this->client, 'Error/Error503.txt');
+            $response = $this->client->getUser(['id' => '123456']);
+            $this->fail('An Exception\ClientErrorResponseException for a 503 response should have been raised');
+        }
+        catch (Exception\ServerErrorResponseException $expected) {
+            $errors = $expected->getErrors();
+            $this->assertEquals(1, count($errors));
+            $this->assertEquals('service_unavailable', $errors[0]['code'] );
+            $this->assertEquals('Sorry, the API service is temporarily unavailable', $errors[0]['message'] );
+        }
+    }
+
+    public function test503ExceptionELB()
+    {
+        try {
+            $this->setMockResponse($this->client, 'Error/Error503ELB.txt');
+            $response = $this->client->getUser(['id' => '123456']);
+            $this->fail('An Exception\ClientErrorResponseException for a 503 ELB response should have been raised');
+        }
+        catch (Exception\ServerErrorResponseException $expected) {
+            $errors = $expected->getErrors();
+            $this->assertEquals(1, count($errors));
+            $this->assertEquals('Service Unavailable: Back-end server is at capacity', $errors[0]['message'] );
+        }
+    }
+}

tests/Mock/Error/Error503.txt

@@ -0,0 +1,13 @@
+HTTP/1.1 503 Service Unavailable
+Content-Type: application/json; charset=utf-8
+Date: Mon, 25 Aug 2014 23:57:54 GMT
+
+{
+    "type": "error.list",
+    "errors": [
+        {
+            "code": "service_unavailable",
+            "message": "Sorry, the API service is temporarily unavailable"
+        }
+    ]
+}

tests/Mock/Error/Error503ELB.txt

@@ -0,0 +1,3 @@
+HTTP/1.1 503 Service Unavailable: Back-end server is at capacity
+Content-Length: 0
+Connection: keep-alive