Skip to content

Commit 4f1ad2b

Browse files
author
Dominic Scheirlinck
committed
Use first header, not array to int cast
1 parent 3bf523d commit 4f1ad2b

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

src/IntercomClient.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -220,13 +220,13 @@ private function setRateLimitDetails(Response $response)
220220
{
221221
$this->rateLimitDetails = [
222222
'limit' => $response->hasHeader('X-RateLimit-Limit')
223-
? (int)$response->getHeader('X-RateLimit-Limit')
223+
? (int)$response->getHeader('X-RateLimit-Limit')[0]
224224
: null,
225225
'remaining' => $response->hasHeader('X-RateLimit-Remaining')
226-
? (int)$response->getHeader('X-RateLimit-Remaining')
226+
? (int)$response->getHeader('X-RateLimit-Remaining')[0]
227227
: null,
228228
'reset_at' => $response->hasHeader('X-RateLimit-Reset')
229-
? (new \DateTimeImmutable())->setTimestamp((int)$response->getHeader('X-RateLimit-Reset'))
229+
? (new \DateTimeImmutable())->setTimestamp((int)$response->getHeader('X-RateLimit-Reset')[0])
230230
: null,
231231
];
232232
}

test/IntercomClientTest.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,9 @@ public function testPaginationHelper()
6363

6464
public function testRateLimitDetails()
6565
{
66+
$time = time() + 7;
6667
$mock = new MockHandler([
67-
new Response(200, ['X-RateLimit-Limit' => '83', 'X-RateLimit-Remaining' => '2', 'X-RateLimit-Reset' => time() + 7], "{\"foo\":\"bar\"}")
68+
new Response(200, ['X-RateLimit-Limit' => '83', 'X-RateLimit-Remaining' => '2', 'X-RateLimit-Reset' => $time], "{\"foo\":\"bar\"}")
6869
]);
6970

7071
$container = [];
@@ -86,5 +87,8 @@ public function testRateLimitDetails()
8687
$this->assertArrayHasKey('limit', $rateLimitDetails);
8788
$this->assertArrayHasKey('remaining', $rateLimitDetails);
8889
$this->assertArrayHasKey('reset_at', $rateLimitDetails);
90+
$this->assertEquals(83, $rateLimitDetails['limit']);
91+
$this->assertEquals(2, $rateLimitDetails['remaining']);
92+
$this->assertEquals((new DateTimeImmutable)->setTimestamp($time), $rateLimitDetails['reset_at']);
8993
}
9094
}

0 commit comments

Comments
 (0)