Add linting to CI (#266)

GabrielAnca · web-flow · commit 6c4905f61bbd · 2018-09-10T10:58:30.000+01:00
* Add Intercom\Test namespace to all the tests

* Enforce PSR2 by CI

* Fix PHPUnit imports

* Import PHPUnit_Framework_TestCase
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -10,3 +10,4 @@ jobs:
       - checkout
       - run: composer install --no-interaction
       - run: vendor/bin/phpunit
+      - run: vendor/bin/phpcs --standard=PSR2 src test
diff --git a/composer.json b/composer.json
@@ -14,6 +14,11 @@
             "Intercom\\": ["src"]
         }
     },
+    "autoload-dev": {
+        "psr-4": {
+            "Intercom\\Test\\": ["test"]
+        }
+    },
     "require": {
         "php": ">= 5.6",
         "ext-json": "*",
diff --git a/test/IntercomAdminsTest.php b/test/IntercomAdminsTest.php
@@ -1,6 +1,9 @@
 <?php
 
+namespace Intercom\Test;
+
 use Intercom\IntercomAdmins;
+use PHPUnit_Framework_TestCase;
 
 class IntercomAdminsTest extends PHPUnit_Framework_TestCase
 {
diff --git a/test/IntercomBulkTest.php b/test/IntercomBulkTest.php
@@ -1,6 +1,9 @@
 <?php
 
+namespace Intercom\Test;
+
 use Intercom\IntercomBulk;
+use PHPUnit_Framework_TestCase;
 
 class IntercomBulkTest extends PHPUnit_Framework_TestCase
 {
diff --git a/test/IntercomClientTest.php b/test/IntercomClientTest.php
@@ -1,11 +1,16 @@
 <?php
 
+namespace Intercom\Test;
+
+use DateTimeImmutable;
 use Intercom\IntercomClient;
 use GuzzleHttp\Client;
 use GuzzleHttp\Handler\MockHandler;
 use GuzzleHttp\Psr7\Response;
 use GuzzleHttp\HandlerStack;
 use GuzzleHttp\Middleware;
+use PHPUnit_Framework_TestCase;
+use stdClass;
 
 class IntercomClientTest extends PHPUnit_Framework_TestCase
 {
diff --git a/test/IntercomCompaniesTest.php b/test/IntercomCompaniesTest.php
@@ -1,12 +1,9 @@
 <?php
 
+namespace Intercom\Test;
+
 use Intercom\IntercomCompanies;
-use Intercom\IntercomClient;
-use GuzzleHttp\Client;
-use GuzzleHttp\Handler\MockHandler;
-use GuzzleHttp\Psr7\Response;
-use GuzzleHttp\HandlerStack;
-use GuzzleHttp\Middleware;
+use PHPUnit_Framework_TestCase;
 
 class IntercomCompaniesTest extends PHPUnit_Framework_TestCase
 {
diff --git a/test/IntercomConversationsTest.php b/test/IntercomConversationsTest.php
@@ -1,12 +1,9 @@
 <?php
 
+namespace Intercom\Test;
+
 use Intercom\IntercomConversations;
-use Intercom\IntercomClient;
-use GuzzleHttp\Client;
-use GuzzleHttp\Handler\MockHandler;
-use GuzzleHttp\Psr7\Response;
-use GuzzleHttp\HandlerStack;
-use GuzzleHttp\Middleware;
+use PHPUnit_Framework_TestCase;
 
 class IntercomConversationsTest extends PHPUnit_Framework_TestCase
 {
diff --git a/test/IntercomCountsTest.php b/test/IntercomCountsTest.php
@@ -1,6 +1,9 @@
 <?php
 
+namespace Intercom\Test;
+
 use Intercom\IntercomCounts;
+use PHPUnit_Framework_TestCase;
 
 class IntercomCountsTest extends PHPUnit_Framework_TestCase
 {
diff --git a/test/IntercomEventsTest.php b/test/IntercomEventsTest.php
@@ -1,12 +1,9 @@
 <?php
 
+namespace Intercom\Test;
+
 use Intercom\IntercomEvents;
-use Intercom\IntercomClient;
-use GuzzleHttp\Client;
-use GuzzleHttp\Handler\MockHandler;
-use GuzzleHttp\Psr7\Response;
-use GuzzleHttp\HandlerStack;
-use GuzzleHttp\Middleware;
+use PHPUnit_Framework_TestCase;
 
 class IntercomEventsTest extends PHPUnit_Framework_TestCase
 {
diff --git a/test/IntercomLeadsTest.php b/test/IntercomLeadsTest.php
@@ -1,6 +1,9 @@
 <?php
 
+namespace Intercom\Test;
+
 use Intercom\IntercomLeads;
+use PHPUnit_Framework_TestCase;
 
 class IntercomLeadsTest extends PHPUnit_Framework_TestCase
 {
diff --git a/test/IntercomMessagesTest.php b/test/IntercomMessagesTest.php
@@ -1,12 +1,9 @@
 <?php
 
+namespace Intercom\Test;
+
 use Intercom\IntercomMessages;
-use Intercom\IntercomClient;
-use GuzzleHttp\Client;
-use GuzzleHttp\Handler\MockHandler;
-use GuzzleHttp\Psr7\Response;
-use GuzzleHttp\HandlerStack;
-use GuzzleHttp\Middleware;
+use PHPUnit_Framework_TestCase;
 
 class IntercomMessagesTest extends PHPUnit_Framework_TestCase
 {
diff --git a/test/IntercomNotesTest.php b/test/IntercomNotesTest.php
@@ -1,6 +1,9 @@
 <?php
 
+namespace Intercom\Test;
+
 use Intercom\IntercomNotes;
+use PHPUnit_Framework_TestCase;
 
 class IntercomNotesTest extends PHPUnit_Framework_TestCase
 {
diff --git a/test/IntercomSegmentsTest.php b/test/IntercomSegmentsTest.php
@@ -1,6 +1,9 @@
 <?php
 
+namespace Intercom\Test;
+
 use Intercom\IntercomSegments;
+use PHPUnit_Framework_TestCase;
 
 class IntercomSegmentTest extends PHPUnit_Framework_TestCase
 {
diff --git a/test/IntercomTagsTest.php b/test/IntercomTagsTest.php
@@ -1,6 +1,9 @@
 <?php
 
+namespace Intercom\Test;
+
 use Intercom\IntercomTags;
+use PHPUnit_Framework_TestCase;
 
 class IntercomTagsTest extends PHPUnit_Framework_TestCase
 {
diff --git a/test/IntercomUsersTest.php b/test/IntercomUsersTest.php
@@ -1,12 +1,9 @@
 <?php
 
+namespace Intercom\Test;
+
 use Intercom\IntercomUsers;
-use Intercom\IntercomClient;
-use GuzzleHttp\Client;
-use GuzzleHttp\Handler\MockHandler;
-use GuzzleHttp\Psr7\Response;
-use GuzzleHttp\HandlerStack;
-use GuzzleHttp\Middleware;
+use PHPUnit_Framework_TestCase;
 
 class IntercomUsersTest extends PHPUnit_Framework_TestCase
 {
diff --git a/test/IntercomVisitorsTest.php b/test/IntercomVisitorsTest.php
@@ -1,6 +1,9 @@
 <?php
 
+namespace Intercom\Test;
+
 use Intercom\IntercomVisitors;
+use PHPUnit_Framework_TestCase;
 
 class IntercomVisitorsTest extends PHPUnit_Framework_TestCase
 {

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,9 @@`
`1`	`1`	`<?php`
`2`	`2`
	`3`	`+namespace Intercom\Test;`
	`4`	`+`
`3`	`5`	`use Intercom\IntercomAdmins;`
	`6`	`+use PHPUnit_Framework_TestCase;`
`4`	`7`
`5`	`8`	`class IntercomAdminsTest extends PHPUnit_Framework_TestCase`
`6`	`9`	`{`