Merge pull request #64 from intercom/jo/remove-admin_id-constraint-on-note

remove requirement of admin_id from note creation

Author: josler

CHANGES.txt

@@ -1,6 +1,10 @@
 Changes
 =========
 
+1.0.0-b7
+
+- Removed requirement for admin_id on note creation
+
 1.0.0-b6
 
 - Added rate limit details to response, thanks @ziemkowski
@@ -29,4 +33,4 @@ Changes
 
 1.0.0-b1
 
- - initial beta release
+ - initial beta release

README.md

@@ -15,7 +15,7 @@ In your composer.json file:
 ```js
 {
     "require": {
-      "intercom/intercom-php": "1.0.0-b5"
+      "intercom/intercom-php": "1.0.0-b7"
     }
 }
 ```

src/Intercom/Service/config/intercom_public_note.json

@@ -46,7 +46,6 @@
             "parameters": {
                 "admin_id": {
                     "location": "json",
-                    "required": true,
                     "type": "string"
                 },
                 "user": {

tests/Intercom/Resources/NoteTest.php

@@ -55,6 +55,14 @@ public function testCreateNote()
         $this->assertRequestJson(['admin_id' => '6', 'user' => ['email' => '[email protected]'], 'body' => 'Hi']);
     }
 
+    public function testCreateNoteWithoutAdmin() {
+      $this->setMockResponse($this->client, 'Note/Note.txt');
+      $this->client->createNote(['user' => ['email' => '[email protected]'], 'body' => 'Hi']);
+
+      $this->assertRequest('POST', '/notes');
+      $this->assertRequestJson(['user' => ['email' => '[email protected]'], 'body' => 'Hi']);
+    }
+
     /**
      * @expectedException \Guzzle\Service\Exception\ValidationException
      */
@@ -94,4 +102,4 @@ public function testCreateNoteNoBody()
     {
         $this->client->getNote(['admin_id' => '6', 'user' => ['email' => '[email protected]']]);
     }
-}
+}