Merge pull request #25 from intercom/update_user_tests

Update User tests to test correctness of responses and requests

Author: nurazem

src/intercom/Service/config/intercom_v3_user.json

@@ -197,7 +197,8 @@
                     "type": "string"
                 }
             },
-            "responseType": "string",
+            "responseClass": "UserModel",
+            "responseType": "model",
             "summary": "Deletes a user given id, email or user_id",
             "uri": "/users"
         }

tests/Intercom/Resources/UserTest.php

@@ -2,59 +2,126 @@
 
 namespace Intercom;
 
-use Guzzle\Tests\GuzzleTestCase;
-
 class UserTest extends IntercomTestCase
 {
     public function testGetUserByID()
     {
         $this->setMockResponse($this->client, 'User/User.txt');
-        $response = $this->client->getUser(["id" => "123456"]);
+        $response = $this->client->getUser(['id' => '123456']);
+
+        $this->assertBasicAuth('my-app', '1234');
+        $this->assertRequest('GET', '/users/123456');
+
         $this->assertInstanceOf('\Guzzle\Service\Resource\Model', $response);
-        $this->assertEquals('Joe Schmoe', $response["name"]);
+        $this->assertEquals('Joe Schmoe', $response['name']);
     }
 
     public function testGetUserByEmail()
     {
         $this->setMockResponse($this->client, 'User/User.txt');
-        $response = $this->client->getUser(["email" => "[email protected]"]);
-        $this->assertInstanceOf('\Guzzle\Service\Resource\Model', $response);
-        $this->assertEquals('Joe Schmoe', $response["name"]);
+        $this->client->getUser(['email' => '[email protected]']);
+
+        $this->assertRequest('GET', '/users/?email=a%40example.org');
     }
 
     public function testGetUserByUserID()
     {
         $this->setMockResponse($this->client, 'User/User.txt');
-        $response = $this->client->getUser(["user_id" => "hgsdfhsasdfg"]);
-        $this->assertInstanceOf('\Guzzle\Service\Resource\Model', $response);
-        $this->assertEquals('Joe Schmoe', $response["name"]);
+        $this->client->getUser(['user_id' => 'hgsdfhsasdfg']);
+
+        $this->assertRequest('GET', '/users/?user_id=hgsdfhsasdfg');
     }
 
     public function testCreateUser()
     {
         $this->setMockResponse($this->client, 'User/User.txt');
-        $response = $this->client->createUser(["id" => "123456"]);
+        $response = $this->client->createUser(['name' => 'Joe Schmoe', 'email' => '[email protected]', 'hi' => 'hello']);
+
+        $this->assertRequest('POST', '/users');
+        $this->assertRequestJson(['email' => '[email protected]', 'name' => 'Joe Schmoe']);
+
         $this->assertInstanceOf('\Guzzle\Service\Resource\Model', $response);
-        $this->assertEquals('Joe Schmoe', $response["name"]);
+        $this->assertEquals('Joe Schmoe', $response['name']);
     }
 
     public function testUpdateUser()
     {
         $this->setMockResponse($this->client, 'User/User.txt');
-        $response = $this->client->updateUser(["id" => "123456", "updated_at" => time()]);
+        $response = $this->client->updateUser(['id' => '123456', 'user_id' => '1234', 'hi' => 'hello']);
+
+        $this->assertRequest('POST', '/users');
+        $this->assertRequestJson(['id' => '123456', 'user_id' => '1234']);
+
+        $this->assertInstanceOf('\Guzzle\Service\Resource\Model', $response);
+        $this->assertEquals('Joe Schmoe', $response['name']);
+    }
+
+    public function testDeleteUserByID()
+    {
+        $this->setMockResponse($this->client, 'User/User.txt');
+        $response = $this->client->deleteUser(['id' => '123456', 'hi' => 'hello']);
+
+        $this->assertRequest('DELETE', '/users');
+        $this->assertRequestJson(['id' => '123456']);
+
         $this->assertInstanceOf('\Guzzle\Service\Resource\Model', $response);
-        $this->assertEquals('Joe Schmoe', $response["name"]);
+        $this->assertEquals('Joe Schmoe', $response['name']);
+    }
+
+    public function testDeleteUserByEmail()
+    {
+        $this->setMockResponse($this->client, 'User/User.txt');
+        $this->client->deleteUser(['email' => '[email protected]', 'hi' => 'hello']);
+
+        $this->assertRequest('DELETE', '/users');
+        $this->assertRequestJson(['email' => '[email protected]']);
+    }
+
+    public function testDeleteUserByUserID()
+    {
+        $this->setMockResponse($this->client, 'User/User.txt');
+        $this->client->deleteUser(['user_id' => '1234', 'hi' => 'hello']);
+
+        $this->assertRequest('DELETE', '/users');
+        $this->assertRequestJson(['user_id' => '1234']);
     }
 
     public function testGetUsers()
     {
-        $this->setMockResponse($this->client, 'User/Users.txt');
+        $this->setMockResponse($this->client, 'User/UserList.txt');
         $response = $this->client->getUsers();
         $users = $response->get('users');
 
+        $this->assertRequest('GET', '/users');
+
         $this->assertInstanceOf('\Guzzle\Service\Resource\Model', $response);
+        $this->assertEquals(3, count($users));
         $this->assertEquals('[email protected]', $users['0']['email']);
         $this->assertEquals('[email protected]', $users['1']['email']);
         $this->assertEquals('[email protected]', $users['2']['email']);
     }
+
+    public function testGetUsersByTagID()
+    {
+        $this->setMockResponse($this->client, 'User/UserList.txt');
+        $this->client->getUsers(['tag_id' => '10', 'hello'=>'hi']);
+
+        $this->assertRequest('GET', '/users?tag_id=10');
+    }
+
+    public function testGetUsersBySegmentID()
+    {
+        $this->setMockResponse($this->client, 'User/UserList.txt');
+        $this->client->getUsers(['segment_id' => '20', 'hello'=>'hi']);
+
+        $this->assertRequest('GET', '/users?segment_id=20');
+    }
+
+    /**
+     * @expectedException \Guzzle\Service\Exception\ValidationException
+     */
+    public function testUpdateUserNoID()
+    {
+        $this->client->updateUser();
+    }
 }