Merge pull request #23 from intercom/refactor/android-rn-0-59-support-fixes

Refactor/android rn 0 59 support fixes

Author: pi0trpietruszewski

README.md

@@ -3,6 +3,7 @@
 [![Version](https://img.shields.io/npm/v/intercom-react-native.svg)](https://www.npmjs.com/package/intercom-react-native)
 [![Documentation](https://img.shields.io/badge/documentation-yes-brightgreen.svg)](https://github.com/intercom/intercom-react-native#readme)
 [![License: Apache--2.0](https://img.shields.io/badge/License-Apache--2.0-yellow.svg)](https://github.com/intercom/intercom-react-native#readme)
+[![CircleCi](https://circleci.com/gh/intercom/intercom-react-native.svg?style=shield)](https://github.com/intercom/intercom-react-native#readme)
 
 > React Native wrapper to bridge our iOS and Android SDK
 
@@ -56,14 +57,14 @@ $ react-native link @intercom/intercom-react-native
 - Add below code to `android/settings.gradle`
 
 ```Gradle
-include ':intercomreactnative'
-project(':intercomreactnative').projectDir = new File(rootProject.projectDir, '../../android')
+include ':intercom-react-native'
+project(':intercom-react-native').projectDir = new File(rootProject.projectDir, '../node_modules/@intercom/intercom-react-native/android')
 ```
 
 - Then edit `android/app/build.gradle`, inside `dependencies` at very bottom add
 
 ```Gradle
-implementation project(':intercomreactnative')
+implementation project(':intercom-react-native')
 ```
 
 #### Android: Setup

android/src/main/java/com/intercom/reactnative/IntercomHelpCenterHelpers.java

@@ -18,7 +18,7 @@
 
 public class IntercomHelpCenterHelpers {
 
-  public static ReadableArray parseArticlesToReadableArray(List<HelpCenterArticle> itemArticles) {
+  public static WritableArray parseArticlesToReadableArray(List<HelpCenterArticle> itemArticles) {
     WritableArray articles = Arguments.createArray();
 
     HelpCenterArticle[] articlesArray = new HelpCenterArticle[itemArticles.size()];
@@ -33,7 +33,7 @@ public static ReadableArray parseArticlesToReadableArray(List<HelpCenterArticle>
     return articles;
   }
 
-  public static ReadableArray parseHelpCenterArticleSearchToReadableArray(List<HelpCenterArticleSearchResult> helpCenterArticleSearchResultList) {
+  public static WritableArray parseHelpCenterArticleSearchToReadableArray(List<HelpCenterArticleSearchResult> helpCenterArticleSearchResultList) {
     WritableArray articles = Arguments.createArray();
 
     HelpCenterArticleSearchResult[] articlesArray = new HelpCenterArticleSearchResult[helpCenterArticleSearchResultList.size()];
@@ -50,35 +50,35 @@ public static ReadableArray parseHelpCenterArticleSearchToReadableArray(List<Hel
     return articles;
   }
 
-  public static ReadableMap parseHelpCenterCollectionsContentToReadableMap(HelpCenterCollectionContent helpCenterCollectionContent) {
+  public static WritableMap parseHelpCenterCollectionsContentToReadableMap(HelpCenterCollectionContent helpCenterCollectionContent) {
     WritableMap helpCenterCollection = Arguments.createMap();
     helpCenterCollection.putString("id", helpCenterCollectionContent.getCollectionId());
     helpCenterCollection.putString("title", helpCenterCollectionContent.getTitle());
     helpCenterCollection.putString("summary", helpCenterCollectionContent.getSummary());
 
-    ReadableArray articles = parseArticlesToReadableArray(helpCenterCollectionContent.getHelpCenterArticles());
+    WritableArray articles = parseArticlesToReadableArray(helpCenterCollectionContent.getHelpCenterArticles());
     helpCenterCollection.putArray("articles", articles);
 
-    ReadableArray sections = parseHelpCenterSectionsToReadableArray(helpCenterCollectionContent.getHelpCenterSections());
+    WritableArray sections = parseHelpCenterSectionsToReadableArray(helpCenterCollectionContent.getHelpCenterSections());
     helpCenterCollection.putArray("sections", sections);
 
 
     return helpCenterCollection;
   }
 
-  public static ReadableMap parseHelpCenterSectionToReadableMap(HelpCenterSection helpCenterSection) {
+  public static WritableMap parseHelpCenterSectionToReadableMap(HelpCenterSection helpCenterSection) {
     WritableMap section = Arguments.createMap();
     section.putString("title", helpCenterSection.getTitle());
 
 
-    ReadableArray articles = parseArticlesToReadableArray(helpCenterSection.getHelpCenterArticles());
+    WritableArray articles = parseArticlesToReadableArray(helpCenterSection.getHelpCenterArticles());
     section.putArray("articles", articles);
 
 
     return section;
   }
 
-  public static ReadableArray parseHelpCenterSectionsToReadableArray(List<HelpCenterSection> helpCenterSectionList) {
+  public static WritableArray parseHelpCenterSectionsToReadableArray(List<HelpCenterSection> helpCenterSectionList) {
     WritableArray sections = Arguments.createArray();
 
     HelpCenterSection[] sectionsArray = new HelpCenterSection[helpCenterSectionList.size()];
@@ -91,7 +91,7 @@ public static ReadableArray parseHelpCenterSectionsToReadableArray(List<HelpCent
     return sections;
   }
 
-  public static ReadableArray parseHelpCenterCollectionsToReadableArray(List<HelpCenterCollection> helpCenterCollections) {
+  public static WritableArray parseHelpCenterCollectionsToReadableArray(List<HelpCenterCollection> helpCenterCollections) {
     HelpCenterCollection[] collectionsArray = new HelpCenterCollection[helpCenterCollections.size()];
     collectionsArray = helpCenterCollections.toArray(collectionsArray);
     WritableArray collections = Arguments.createArray();