Skip to content

Commit a11e72b

Browse files
fix: remove event emitter warnings
1 parent c1b3feb commit a11e72b

File tree

2 files changed

+20
-4
lines changed

2 files changed

+20
-4
lines changed

android/src/main/java/com/intercom/reactnative/IntercomEventEmitter.java

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,16 @@ public IntercomEventEmitter(ReactApplicationContext reactContext) {
3333
super(reactContext);
3434
}
3535

36+
@ReactMethod
37+
public void addListener(String eventName) {
38+
// Keep: Required for RN built in Event Emitter Calls.
39+
}
40+
41+
@ReactMethod
42+
public void removeListeners(Integer count) {
43+
// Keep: Required for RN built in Event Emitter Calls.
44+
}
45+
3646
@ReactMethod
3747
public void startEventListener() {
3848
try {

example/src/App.tsx

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ export default function App() {
8181
/**
8282
* Handle PushNotification
8383
*/
84-
AppState.addEventListener(
84+
const appChangeListener = AppState.addEventListener(
8585
'change',
8686
(nextAppState) =>
8787
nextAppState === 'active' && Intercom.handlePushMessage()
@@ -90,7 +90,7 @@ export default function App() {
9090
/**
9191
* Handle Push Notification deep links
9292
*/
93-
Linking.addEventListener('url', (event) => {
93+
const urlListener = Linking.addEventListener('url', (event) => {
9494
if (event) {
9595
Alert.alert(event.url);
9696
}
@@ -116,8 +116,14 @@ export default function App() {
116116

117117
return () => {
118118
countListener.remove();
119-
Linking.removeEventListener('url', () => {});
120-
AppState.removeEventListener('change', () => {});
119+
120+
// @ts-ignore - type definitions haven't been updated to 0.65 yet
121+
urlListener.remove(); // <- for RN 0.65+
122+
// Linking.removeEventListener('url', () => {}); <- for RN < 0.65
123+
124+
// @ts-ignore - type definitions haven't been updated to 0.65 yet
125+
appChangeListener.remove(); // <- for RN 0.65+
126+
//AppState.removeEventListener('change', () => {}); <- for RN < 0.65
121127
};
122128
}, []);
123129

0 commit comments

Comments
 (0)