test: ui test for fetch help center methods

    - android error handling fixes

Author: piotr pietruszewski

android/src/main/java/com/intercom/reactnative/IntercomModule.java

@@ -319,7 +319,7 @@ public void onFailure() {
           promise.reject(IntercomErrorCodes.FETCH_HELP_CENTER_COLLECTIONS, "fetchHelpCenterCollections failure");
         }
       };
-
+      Log.d(NAME, "fetchHelpCenterCollections");
       Intercom.client().fetchHelpCenterCollections(collectionRequestCallback);
 
     } catch (Exception err) {
@@ -332,27 +332,30 @@ public void onFailure() {
   @ReactMethod
   public void fetchHelpCenterCollection(String collectionId, Promise promise) {
     try {
-
-      CollectionContentRequestCallback collectionContentCallback = new CollectionContentRequestCallback() {
-        @Override
-        public void onComplete(@NotNull HelpCenterCollectionContent helpCenterCollectionContent) {
-          promise.resolve(IntercomHelpCenterHelpers.parseHelpCenterCollectionsContentToReadableMap(helpCenterCollectionContent));
-        }
-
-        @Override
-        public void onError(int i) {
-          Log.e(NAME, "fetchHelpCenterCollection error");
-          promise.reject(String.valueOf(i), "fetchHelpCenterCollection error");
-        }
-
-        @Override
-        public void onFailure() {
-          Log.e(NAME, "fetchHelpCenterCollection failure");
-          promise.reject(IntercomErrorCodes.FETCH_HELP_CENTER_COLLECTION, "fetchHelpCenterCollection failure");
-        }
-      };
-
-      Intercom.client().fetchHelpCenterCollection(collectionId, collectionContentCallback);
+      if (collectionId.equals("") ) {
+        promise.reject(IntercomErrorCodes.FETCH_HELP_CENTER_COLLECTION, "collectionID can\'t be empty");
+      } else {
+        CollectionContentRequestCallback collectionContentCallback = new CollectionContentRequestCallback() {
+          @Override
+          public void onComplete(@NotNull HelpCenterCollectionContent helpCenterCollectionContent) {
+            promise.resolve(IntercomHelpCenterHelpers.parseHelpCenterCollectionsContentToReadableMap(helpCenterCollectionContent));
+          }
+
+          @Override
+          public void onError(int i) {
+            Log.e(NAME, "fetchHelpCenterCollection error");
+            promise.reject(String.valueOf(i), "fetchHelpCenterCollection error");
+          }
+
+          @Override
+          public void onFailure() {
+            Log.e(NAME, "fetchHelpCenterCollection failure");
+            promise.reject(IntercomErrorCodes.FETCH_HELP_CENTER_COLLECTION, "fetchHelpCenterCollection failure");
+          }
+        };
+        Log.d(NAME, "fetchHelpCenterCollection");
+        Intercom.client().fetchHelpCenterCollection(collectionId, collectionContentCallback);
+      }
 
     } catch (Exception err) {
       Log.e(NAME, "fetchHelpCenterCollection error:");
@@ -383,7 +386,7 @@ public void onFailure() {
           promise.reject(IntercomErrorCodes.SEARCH_HELP_CENTER, "searchHelpCenter failure");
         }
       };
-
+      Log.d(NAME, "searchHelpCenter");
       Intercom.client().searchHelpCenter(searchTerm, collectionContentCallback);
 
     } catch (Exception err) {

example/.env.example

@@ -6,3 +6,5 @@ CAROUSEL_ID=$CAROUSEL_ID
 EVENT_NAME=$EVENT_NAME
 ARTICLE_ID=$ARTICLE_ID
 USER_NAME=$USER_NAME
+SECTION_ID=$SECTION_ID
+SEARCH_TERM=$SEARCH_TERM

example/e2e/tests/mainIntercom.e2e.ts

@@ -45,6 +45,25 @@ describe('Intercom E2E', () => {
     await driver.closeHelpCenterOverlay();
   });
 
+  it('Should fetch help center collections', async () => {
+    await driver.scrollToElementByAccessibilityLabel(
+      'fetch-help-center-collections'
+    );
+    await (await $('~fetch-help-center-collections')).click();
+  });
+
+  it('Should fetch help center collection', async () => {
+    await driver.scrollToElementByAccessibilityLabel(
+      'fetch-help-center-collections'
+    );
+    await (await $('~fetch-help-center-collection')).click();
+  });
+
+  it('Should fetch filtered hel center collections', async () => {
+    await driver.scrollToElementByAccessibilityLabel('search-help-center');
+    await (await $('~search-help-center')).click();
+  });
+
   it('Should display carousel', async () => {
     await driver.scrollToElementByAccessibilityLabel('display-carousel');
     await (await $('~display-carousel')).click();

example/scripts/generateEnv.sh

@@ -8,3 +8,5 @@ echo CAROUSEL_ID=$CAROUSEL_ID >>.env
 echo EVENT_NAME=$EVENT_NAME >>.env
 echo ARTICLE_ID=$ARTICLE_ID >>.env
 echo USER_NAME=$USER_NAME >>.env
+echo SEARCH_TERM=$SEARCH_TERM >>.env
+echo SECTION_ID=$SECTION_ID >>.env

example/src/App.tsx

@@ -23,6 +23,8 @@ const CAROUSEL_ID = Config.CAROUSEL_ID;
 const EVENT_NAME = Config.EVENT_NAME;
 const ARTICLE_ID = Config.ARTICLE_ID;
 const USER_NAME = Config.USER_NAME;
+const COLLECTION_ID = Config.COLLECTION_ID;
+const SEARCH_TERM = Config.SEARCH_TERM;
 const TOKEN = Platform.select({
   ios: 'RN-IOS-TOKEN',
   default: 'RN-ANDROID-TOKEN',
@@ -37,6 +39,10 @@ export default function App() {
   const [launcherVisibility, setLauncherVisibility] = useState<boolean>(false);
   const [user, setUser] = useState<Registration>({ email: '' });
 
+  const showErrorAlert = (e: Error) => {
+    Alert.alert('ERROR', JSON.stringify(e));
+  };
+
   useEffect(() => {
     /**
      * Handle PushNotification
@@ -203,6 +209,37 @@ export default function App() {
                 console.log(items);
               })
               .catch((e) => {
+                showErrorAlert(e);
+                console.error(e);
+              });
+          }}
+        />
+        <Button
+          accessibilityLabel="fetch-help-center-collection"
+          disabled={!loggedUser}
+          title="Fetch Help Center Collection"
+          onPress={() => {
+            Intercom.fetchHelpCenterCollection(COLLECTION_ID)
+              .then((item) => {
+                console.log(item);
+              })
+              .catch((e) => {
+                showErrorAlert(e);
+                console.error(e);
+              });
+          }}
+        />
+        <Button
+          accessibilityLabel="search-help-center"
+          disabled={!loggedUser}
+          title="Search Help Center"
+          onPress={() => {
+            Intercom.searchHelpCenter(SEARCH_TERM)
+              .then((item) => {
+                console.log(item);
+              })
+              .catch((e) => {
+                showErrorAlert(e);
                 console.error(e);
               });
           }}

src/index.tsx

@@ -133,7 +133,7 @@ export type IntercomType = {
 const Intercom = {
   searchHelpCenter: (term) => IntercomModule.searchHelpCenter(term),
   fetchHelpCenterCollections: () => IntercomModule.fetchHelpCenterCollections(),
-  fetchHelpCenterCollection: (id) =>
+  fetchHelpCenterCollection: (id = '') =>
     IntercomModule.fetchHelpCenterCollection(id),
   displayArticle: (articleId: string) =>
     IntercomModule.displayArticle(articleId),