Merge pull request #31 from intercom/refactor/update-to-rn-0651

Refactor: Update to RN 0.65.1

Author: maciejBudzinskiNG

.circleci/config.yml

@@ -3,7 +3,7 @@ version: 2.1
 # Default VM config to be used for macOS builds
 macos_config: &macos_config
   macos:
-    xcode: 12.3.0
+    xcode: 12.5.0
   shell: /bin/bash --login -eo pipefail
 
 setup_env_file: &setup_env_file
@@ -109,6 +109,9 @@ jobs:
             yarn prepare
   # Build and Test android version of module
   android-e2e-test:
+    environment:
+      GRADLE_OPTS: '-Dorg.gradle.jvmargs="-Xmx2048m -XX:+HeapDumpOnOutOfMemoryError"'
+      JAVA_OPTS: '-Xms512m -Xmx1024m'
     executor:
       name: android/android-machine
     working_directory: ~/project

README.md

@@ -227,12 +227,13 @@ public class MainNotificationService extends FirebaseMessagingService {
     /**
      * Handle PushNotification
      */
-    AppState.addEventListener(
+    const appStateListener = AppState.addEventListener(
       'change',
       (nextAppState) =>
         nextAppState === 'active' && Intercom.handlePushMessage()
     );
-    return () => AppState.removeEventListener('change', () => true);
+    return () => AppState.removeEventListener('change', () => true); // <- for RN < 0.65
+    return () => appStateListener.remove() // <- for RN >= 0.65
   }
   , [])
 ```
@@ -621,16 +622,14 @@ Handles the opening of an Intercom push message. This will retrieve the URI from
   /**
    * Handle PushNotification Open
    */
-  AppState.addEventListener(
+  const appStateListener = AppState.addEventListener(
     'change',
     (nextAppState) =>
       nextAppState === 'active' && Intercom.handlePushMessage()
   );
 
-  return () => {
-    AppState.removeEventListener('change', () => {
-    });
-  };
+  return () => AppState.removeEventListener('change', () => {}); // <- for RN < 0.65
+  return () => appStateListener.remove(); // <- for RN >= 0.65
 }, []);
 ```
 

android/build.gradle

@@ -7,7 +7,7 @@ buildscript {
     if (project == rootProject) {
         repositories {
             google()
-            jcenter()
+            mavenCentral()
         }
 
         dependencies {
@@ -23,15 +23,13 @@ def safeExtGet(prop, fallback) {
 }
 
 android {
-    compileSdkVersion safeExtGet('IntercomReactNative_compileSdkVersion', 29)
-    buildToolsVersion safeExtGet('IntercomReactNative_buildToolsVersion', '29.0.2')
+    compileSdkVersion safeExtGet('IntercomReactNative_compileSdkVersion', 30)
     defaultConfig {
         minSdkVersion safeExtGet('IntercomReactNative_minSdkVersion', 21)
-        targetSdkVersion safeExtGet('IntercomReactNative_targetSdkVersion', 29)
+        targetSdkVersion safeExtGet('IntercomReactNative_targetSdkVersion', 30)
         versionCode 1
         versionName "1.0"
         buildConfigField 'String', 'INTERCOM_VERSION_NAME', packageVersion
-
     }
 
     buildTypes {
@@ -49,18 +47,18 @@ android {
 }
 
 repositories {
+    mavenCentral()
     mavenLocal()
     maven {
         // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
         url("$rootDir/../node_modules/react-native/android")
     }
     google()
-    jcenter()
 }
 
 dependencies {
     //noinspection GradleDynamicVersion
     implementation "com.facebook.react:react-native:+"  // From node_modules
     implementation 'com.google.firebase:firebase-messaging:20.2.+'
-    implementation 'io.intercom.android:intercom-sdk:10.+'
+    implementation 'io.intercom.android:intercom-sdk:10.1.+'
 }

android/src/main/java/com/intercom/reactnative/IntercomEventEmitter.java

@@ -33,6 +33,16 @@ public IntercomEventEmitter(ReactApplicationContext reactContext) {
     super(reactContext);
   }
 
+  @ReactMethod
+  public void addListener(String eventName) {
+    // Keep: Required for RN built in Event Emitter Calls.
+  }
+
+  @ReactMethod
+  public void removeListeners(Integer count) {
+    // Keep: Required for RN built in Event Emitter Calls.
+  }
+
   @ReactMethod
   public void startEventListener() {
     try {

example/android/app/build.gradle

@@ -126,13 +126,9 @@ def jscFlavor = 'org.webkit:android-jsc:+'
 def enableHermes = project.ext.react.get("enableHermes", false);
 
 android {
+    ndkVersion rootProject.ext.ndkVersion
     compileSdkVersion rootProject.ext.compileSdkVersion
 
-    compileOptions {
-        sourceCompatibility JavaVersion.VERSION_1_8
-        targetCompatibility JavaVersion.VERSION_1_8
-    }
-
     defaultConfig {
         applicationId "com.example.intercomreactnative"
         minSdkVersion rootProject.ext.minSdkVersion
@@ -186,18 +182,21 @@ android {
         variant.outputs.each { output ->
             // For each separate APK per architecture, set a unique version code as described here:
             // https://developer.android.com/studio/build/configure-apk-splits.html
+            // Example: versionCode 1 will generate 1001 for armeabi-v7a, 1002 for x86, etc.
             def versionCodes = ["armeabi-v7a": 1, "x86": 2, "arm64-v8a": 3, "x86_64": 4]
             def abi = output.getFilter(OutputFile.ABI)
             if (abi != null) {  // null for the universal-debug, universal-release variants
                 output.versionCodeOverride =
-                        versionCodes.get(abi) * 1048576 + defaultConfig.versionCode
+                        defaultConfig.versionCode * 1000 + versionCodes.get(abi)
             }
 
         }
     }
 }
 
 dependencies {
+    // implementation("com.squareup.okhttp3:okhttp-urlconnection:4.9.1") <- required for applications that uses RN < 0.65
+
     implementation fileTree(dir: "libs", include: ["*.jar"])
     //noinspection GradleDynamicVersion
     implementation "com.facebook.react:react-native:+"  // From node_modules
@@ -232,7 +231,7 @@ dependencies {
 // Run this once to be able to run the application with BUCK
 // puts all compile dependencies into folder libs for BUCK to use
 task copyDownloadableDepsToLibs(type: Copy) {
-    from configurations.compile
+    from configurations.implementation
     into 'libs'
 }
 

example/android/app/src/debug/AndroidManifest.xml

@@ -4,5 +4,10 @@
 
     <uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>
 
-    <application android:usesCleartextTraffic="true" tools:targetApi="28" tools:ignore="GoogleAppIndexingWarning" />
+     <application
+        android:usesCleartextTraffic="true"
+        tools:targetApi="28"
+        tools:ignore="GoogleAppIndexingWarning">
+        <activity android:name="com.facebook.react.devsupport.DevSettingsActivity" />
+    </application>
 </manifest>

example/android/app/src/main/AndroidManifest.xml

@@ -34,7 +34,5 @@
         android:name="com.intercom.reactnative.RNIntercomPushBroadcastReceiver"
         tools:replace="android:exported"
         android:exported="true" />
-      <activity android:name="com.facebook.react.devsupport.DevSettingsActivity" />
     </application>
-
 </manifest>

example/android/app/src/main/res/values/styles.xml

@@ -1,7 +1,7 @@
 <resources>
 
     <!-- Base application theme. -->
-    <style name="AppTheme" parent="Theme.AppCompat.Light.NoActionBar">
+    <style name="AppTheme" parent="Theme.AppCompat.DayNight.NoActionBar">
         <!-- Customize your theme here. -->
         <item name="android:textColor">#000000</item>
     </style>

example/android/build.gradle

@@ -5,17 +5,18 @@ buildscript {
   def isFoss = taskRequests.contains("foss")
 
     ext {
-        buildToolsVersion = "29.0.2"
+        buildToolsVersion = "30.0.2"
         minSdkVersion = 21
-        compileSdkVersion = 29
-        targetSdkVersion = 29
+        compileSdkVersion = 30
+        targetSdkVersion = 30
+        ndkVersion = "20.1.5948944"
     }
     repositories {
         google()
-        jcenter()
+        mavenCentral()
     }
     dependencies {
-        classpath("com.android.tools.build:gradle:4.0.1")
+        classpath("com.android.tools.build:gradle:4.2.1")
 
         // NOTE: Do not place your application dependencies here; they belong
         // in the individual module build.gradle files
@@ -27,6 +28,7 @@ buildscript {
 
 allprojects {
     repositories {
+        mavenCentral()
         mavenLocal()
         maven {
             // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
@@ -38,7 +40,7 @@ allprojects {
         }
 
         google()
-        jcenter()
+
         maven { url 'https://www.jitpack.io' }
     }
 }

example/android/gradle.properties

@@ -19,4 +19,4 @@
 
 android.useAndroidX=true
 android.enableJetifier=true
-FLIPPER_VERSION=0.54.0
+FLIPPER_VERSION=0.93.0