Merge pull request #121 from intercom/jo/multiple-matching-users-exception

named multiple-matching-users exception

Author: josler

lib/intercom/errors.rb

@@ -37,6 +37,9 @@ class RateLimitExceeded < IntercomError; end
 
   # Raised when the request throws an error not accounted for
   class UnexpectedError < IntercomError; end
+  
+  # Raised when multiple users match the query (typically duplicate email addresses)
+  class MultipleMatchingUsersError < IntercomError; end
 
   # Raised when you try to call a non-setter method that does not exist on an object
   class Intercom::AttributeNotSetError < IntercomError ; end

lib/intercom/request.rb

@@ -127,6 +127,8 @@ def raise_application_errors_on_failure(error_list_details, http_code)
         raise Intercom::RateLimitExceeded.new(error_details['message'], error_context)
       when 'service_unavailable'
         raise Intercom::ServiceUnavailableError.new(error_details['message'], error_context)
+      when 'conflict'
+        raise Intercom::MultipleMatchingUsersError.new(error_details['message'], error_context)
       when nil, ''
         raise Intercom::UnexpectedError.new(message_for_unexpected_error_without_type(error_details, parsed_http_code), error_context)
       else

spec/unit/intercom_spec.rb

@@ -16,6 +16,11 @@
       Intercom.app_api_key = nil
       proc { Intercom.target_base_url }.must_raise ArgumentError, "You must set both Intercom.app_id and Intercom.app_api_key to use this client. See https://github.com/intercom/intercom-ruby for usage examples."
     end
+    
+    it 'raises an Intercom::MultipleMatchingUsers error when receiving a conflict' do
+      multiple_matching_error = { 'type' => 'error.list', 'errors' => [{ 'code' => 'conflict', 'message' => 'Multiple existing users match this email address - must be more specific using user_id' }]}
+      proc {Intercom::Request.new('/users', :get).raise_application_errors_on_failure(multiple_matching_error, 400)}.must_raise(Intercom::MultipleMatchingUsersError)
+    end
 
     it "returns the app_id and app_api_key previously set" do
       Intercom.app_id.must_equal "abc123"