Raise ResourceNotFound when company is not found (fixes #484) (#485)

Raise ResourceNotFound when company is not found (fixes #484)

Author: jonnyom

lib/intercom/request.rb

@@ -171,7 +171,7 @@ def raise_application_errors_on_failure(error_list_details, http_code)
         raise Intercom::BadRequestError.new(error_details['message'], error_context)
       when "not_restorable"
         raise Intercom::BlockedUserError.new(error_details['message'], error_context)
-      when "not_found"
+      when "not_found", "company_not_found"
         raise Intercom::ResourceNotFound.new(error_details['message'], error_context)
       when "admin_not_found"
         raise Intercom::AdminNotFound.new(error_details['message'], error_context)

spec/unit/intercom/request_spec.rb

@@ -37,7 +37,7 @@
         req = Intercom::Request.get(uri, "")
         req.handle_rate_limit=true
         req.expects(:sleep).times(3).with(any_parameters)
-        req.execute(target_base_url=uri, username: "ted", secret: "")
+        req.execute(uri, username: "ted", secret: "")
       }.must_raise(Intercom::RateLimitExceeded)
     end
 
@@ -48,7 +48,7 @@
       req = Intercom::Request.get(uri, "")
       req.handle_rate_limit=true
       req.expects(:sleep).never.with(any_parameters)
-      req.execute(target_base_url=uri, username: "ted", secret: "")
+      req.execute(uri, username: "ted", secret: "")
     end
 
     it 'should call sleep for rate limit error just once' do
@@ -59,7 +59,7 @@
       req = Intercom::Request.get(uri, "")
       req.handle_rate_limit=true
       req.expects(:sleep).with(any_parameters)
-      req.execute(target_base_url=uri, username: "ted", secret: "")
+      req.execute(uri, username: "ted", secret: "")
     end
 
     it 'should not sleep if rate limit reset time has passed' do
@@ -70,7 +70,7 @@
       req = Intercom::Request.get(uri, "")
       req.handle_rate_limit=true
       req.expects(:sleep).never.with(any_parameters)
-      req.execute(target_base_url=uri, username: "ted", secret: "")
+      req.execute(uri, username: "ted", secret: "")
     end
   end
 
@@ -82,7 +82,7 @@
       stub_request(:put, uri).\
       to_return(status: [409, "Resource Already Exists"], headers: { 'X-RateLimit-Reset' => (Time.now.utc + 10).to_i.to_s }, body: {type: "error.list", errors: [ code: "resource_conflict" ]}.to_json)
       req = Intercom::Request.put(uri, "")
-      expect { req.execute(target_base_url=uri, username: "ted", secret: "") }.must_raise(Intercom::ResourceNotUniqueError)
+      expect { req.execute(uri, username: "ted", secret: "") }.must_raise(Intercom::ResourceNotUniqueError)
     end
 
     it 'should raise ApiVersionInvalid error on intercom_version_invalid code' do
@@ -92,6 +92,13 @@
       req = Intercom::Request.put(uri, "")
       expect { req.execute(uri, username: "ted", secret: "") }.must_raise(Intercom::ApiVersionInvalid)
     end
+
+    it 'should raise ResourceNotFound error on company_not_found code' do
+      stub_request(:put, uri).\
+      to_return(status: [404, "Not Found"], headers: { 'X-RateLimit-Reset' => (Time.now.utc + 10).to_i.to_s }, body: {type: "error.list", errors: [ code: "company_not_found" ]}.to_json)
+      req = Intercom::Request.put(uri, "")
+      expect { req.execute(uri, username: "ted", secret: "") }.must_raise(Intercom::ResourceNotFound)
+    end
   end
 
   it 'parse_body returns nil if decoded_body is nil' do