Merge pull request #238 from dhiemstra/conversation_count_all

Get global conversation count

Author: choran

lib/intercom/service/count.rb

@@ -15,7 +15,9 @@ def for_app
       end
 
       def for_type(type:, count: nil)
-        find(type: type, count: count)
+        params = {type: type}
+        params[:count] = count if count
+        find(params)
       end
     end
   end

spec/spec_helper.rb

@@ -520,6 +520,18 @@ def test_segment_count
   }
 end
 
+def test_conversation_count
+  {
+    "type" => "count",
+    "conversation" => {
+      "assigned" => 1,
+      "closed" => 15,
+      "open" => 1,
+      "unassigned" => 0
+    }
+  }
+end
+
 def error_on_modify_frozen
   RUBY_VERSION =~ /1.8/ ? TypeError : RuntimeError
 end

spec/unit/intercom/count_spec.rb

@@ -14,4 +14,15 @@
     counts = client.counts.for_type(type: 'user', count: 'segment')
     counts.user['segment'][4]["segment 1"].must_equal(1)
   end
+
+  it 'should not include count param when nil' do
+    client.expects(:get).with("/counts", {type: 'conversation'}).returns(test_conversation_count)
+    counts = client.counts.for_type(type: 'conversation')
+    counts.conversation.must_equal({
+      "assigned" => 1,
+      "closed" => 15,
+      "open" => 1,
+      "unassigned" => 0
+    })
+  end
 end