Merge pull request #140 from intercom/jo/parse-collections-with-nil-lists

deal with nils in collection lists

Author: josler

lib/intercom/lib/typed_json_deserializer.rb

@@ -31,6 +31,7 @@ def list_object_type?(object_type)
         end
 
         def deserialize_collection(collection_json)
+          return [] if collection_json == nil
           collection_json.map { |item_json| TypedJsonDeserializer.new(item_json).deserialize }
         end
 

spec/unit/intercom/notification_spec.rb

@@ -41,5 +41,28 @@
     payload = Intercom::Notification.new(test_conversation_notification)
     payload.model.user.must_be_instance_of Intercom::User
   end
+  
+  it "returns inner User object with nil tags" do
+    user_notification = {
+      "type" => "notification_event",
+      "app_id" => "aa11aa",
+      "data" => {
+        "type" => "notification_event_data",
+        "item" => {
+          "type" => "user",
+          "id" => "abc123def",
+          "user_id" => "666",
+          "email" => "[email protected]",
+          "name" => "Joe",
+          "tags" => {
+            "type" => "tag.list",
+            "tags" => nil
+          }
+        }
+      },  
+    }
+    payload = Intercom::Notification.new(user_notification)
+    payload.model.tags.must_equal([])
+  end
 
-end
+end