Merge pull request #66 from intercom/strip-blank-responses

don't parse blank responses as json

Author: josler

lib/intercom/request.rb

@@ -62,7 +62,7 @@ def execute(target_base_url=nil)
         response = http.request(net_http_method)
         raise_errors_on_failure(response)
         decoded = decode(response['content-encoding'], response.body)
-        JSON.parse(decoded) unless decoded.empty?
+        JSON.parse(decoded) unless decoded.strip.empty?
       end
     rescue Timeout::Error
       raise Intercom::ServiceUnavailableError

lib/intercom/version.rb

@@ -1,3 +1,3 @@
 module Intercom #:nodoc:
-  VERSION = "0.2.2"
+  VERSION = "0.2.3"
 end

spec/integration/intercom_api_integration_spec.rb

@@ -48,6 +48,12 @@ def fixture(name)
       message_thread.send(expected).wont_be_nil
     end
   end
+  
+  it "handles blank string bodies" do
+    FakeWeb.register_uri(:get, %r(v1/users\?email=), :body => fixture('v1-user'))
+    user = Intercom::User.find(:email => "[email protected]")
+    FakeWeb.register_uri(:post, %r(/events), :status => ["202", "Created"], :body => ' ')
+  end
 
   it "should mark message_thread as read" do
     FakeWeb.register_uri(:get, %r(v1/users/message_threads\?email=somebody), :body => fixture('v1-users-message_threads'))