Add Ruby 1.9.3 support

- we are using the constantize method instead of Object.const_get as ruby 1.9.3 doesn't allow namespaced constants

Author: Chocksy

.travis.yml

@@ -1,3 +1,5 @@
 language: ruby
 rvm:
+  - 1.9.3
   - 2.0.0
+  - 2.1.0

README.md

@@ -11,7 +11,7 @@ For generating Intercom javascript script tags for Rails, please see https://git
 ## Upgrading information
 Version 2 of intercom-ruby is not backwards compatible with previous versions. Be sure to test this new version before deploying to production. One other change you will need to make as part of the upgrade is to set `Intercom.app_api_key` and not set `Intercom.api_key` (you can continue to use your existing API key).
 
-Additionally, the new version uses Ruby 2.
+This version of the gem is compatible with `Ruby 2.1`, `Ruby 2.0` & `Ruby 1.9.3`
 
 ## Installation
 

intercom.gemspec

@@ -25,5 +25,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "fakeweb", ["~> 1.3"]
 
   spec.add_dependency 'json'
-  spec.required_ruby_version = '~> 2.0'
+  spec.required_ruby_version = '>= 1.9.3'
 end

lib/intercom/errors.rb

@@ -3,7 +3,7 @@ module Intercom
   # Base class exception from which all public Intercom exceptions will be derived
   class IntercomError < StandardError
     attr_reader :http_code, :application_error_code
-    def initialize(message, http_code: nil, application_error_code: application_error_code)
+    def initialize(message, http_code = nil, application_error_code = application_error_code)
       @http_code = http_code
       @application_error_code = application_error_code
       super(message)

lib/intercom/utils.rb

@@ -10,6 +10,18 @@ def pluralize(str)
         "#{str}s"
       end
 
+      # the constantize method that exists in rails to allow for ruby 1.9 to get namespaced constants
+      def constantize(camel_cased_word)
+        names = camel_cased_word.split('::')
+        names.shift if names.empty? || names.first.empty?
+
+        constant = Object
+        names.each do |name|
+          constant = constant.const_defined?(name) ? constant.const_get(name) : constant.const_missing(name)
+        end
+        constant
+      end
+
       def resource_class_to_singular_name(resource_class)
         resource_class.to_s.split('::')[-1].downcase
       end
@@ -22,14 +34,14 @@ def constantize_resource_name(resource_name)
         class_name = Utils.singularize(resource_name.capitalize)
         define_lightweight_class(class_name) unless Intercom.const_defined?(class_name, false)
         namespaced_class_name = "Intercom::#{class_name}"
-        Object.const_get(namespaced_class_name)
+        constantize namespaced_class_name
       end
 
       def constantize_singular_resource_name(resource_name)
         class_name = resource_name.split('_').map(&:capitalize).join
         define_lightweight_class(class_name) unless Intercom.const_defined?(class_name, false)
         namespaced_class_name = "Intercom::#{class_name}"
-        Object.const_get(namespaced_class_name )
+        constantize namespaced_class_name
       end
 
       def define_lightweight_class(class_name)

spec/spec_helper.rb

@@ -107,7 +107,7 @@ def test_message
   }
 end
 
-def page_of_users(include_next_link: false)
+def page_of_users(include_next_link= false)
   {
      "type"=>"user.list",
      "pages"=>

spec/unit/intercom/collection_proxy_spec.rb

@@ -3,32 +3,32 @@
 describe Intercom::CollectionProxy do
 
   it "stops iterating if no next link" do
-    Intercom.expects(:get).with("/users", {}).returns(page_of_users(include_next_link:false))
+    Intercom.expects(:get).with("/users", {}).returns(page_of_users(false))
     emails = []
     Intercom::User.all.each { |user| emails << user.email }
     emails.must_equal %W([email protected] [email protected] [email protected])
   end
 
   it "keeps iterating if next link" do
-    Intercom.expects(:get).with("/users", {}).returns(page_of_users(include_next_link:true))
-    Intercom.expects(:get).with('https://api.intercom.io/users?per_page=50&page=2', {}).returns(page_of_users(include_next_link:false))
+    Intercom.expects(:get).with("/users", {}).returns(page_of_users(true))
+    Intercom.expects(:get).with('https://api.intercom.io/users?per_page=50&page=2', {}).returns(page_of_users(false))
     emails = []
     Intercom::User.all.each { |user| emails << user.email }
   end
 
   it "supports indexed array access" do
-    Intercom.expects(:get).with("/users", {}).returns(page_of_users(include_next_link:false))
+    Intercom.expects(:get).with("/users", {}).returns(page_of_users(false))
     Intercom::User.all[0].email.must_equal '[email protected]'
   end
 
   it "supports map" do
-    Intercom.expects(:get).with("/users", {}).returns(page_of_users(include_next_link:false))
+    Intercom.expects(:get).with("/users", {}).returns(page_of_users(false))
     emails = Intercom::User.all.map { |user| user.email }
     emails.must_equal %W([email protected] [email protected] [email protected])
   end
 
   it "supports querying" do
-    Intercom.expects(:get).with("/users", {:tag_name => 'Taggart J'}).returns(page_of_users(include_next_link:false))
+    Intercom.expects(:get).with("/users", {:tag_name => 'Taggart J'}).returns(page_of_users(false))
     Intercom::User.find_all(:tag_name => 'Taggart J').map(&:email).must_equal %W([email protected] [email protected] [email protected])
   end
 end

spec/unit/intercom/event_spec.rb

@@ -2,8 +2,8 @@
 
 describe "Intercom::Event" do
 
-  let (:user) {Intercom::User.new("email" => "[email protected]", :user_id => "12345", :created_at => Time.now, :name => "Jim Bob")}
-  let (:created_time) {Time.now - 300}
+  let(:user) {Intercom::User.new("email" => "[email protected]", :user_id => "12345", :created_at => Time.now, :name => "Jim Bob")}
+  let(:created_time) {Time.now - 300}
 
   it "creates an event with metadata" do
     Intercom.expects(:post).with('/events', {'event_name' => 'Eventful 1', 'created_at' => created_time.to_i, 'email' => '[email protected]', 'metadata' => {'invitee_email' => '[email protected]', :invite_code => 'ADDAFRIEND', 'found_date' => 12909364407}}).returns(:status => 202)

spec/unit/intercom/user_spec.rb

@@ -99,12 +99,13 @@
 
   it "rejects nested data structures in custom_attributes" do
     user = Intercom::User.new()
-    proc { user.custom_attributes["thing"] = [1] }.must_raise ArgumentError
-    proc { user.custom_attributes["thing"] = {1 => 2} }.must_raise ArgumentError
-    proc { user.custom_attributes = {1 => {2 => 3}} }.must_raise ArgumentError
+    
+    proc { user.custom_attributes["thing"] = [1] }.must_raise(ArgumentError)
+    proc { user.custom_attributes["thing"] = {1 => 2} }.must_raise(ArgumentError)
+    proc { user.custom_attributes["thing"] = {1 => {2 => 3}} }.must_raise(ArgumentError)
 
     user = Intercom::User.from_api(test_user)
-    proc { user.custom_attributes["thing"] = [1] }.must_raise ArgumentError
+    proc { user.custom_attributes["thing"] = [1] }.must_raise(ArgumentError)
   end
 
   describe "incrementing custom_attributes fields" do
@@ -199,7 +200,8 @@
   it "sets/gets rw keys" do
     params = {"email" => "[email protected]", :user_id => "abc123", "name" => "Bob Smith", "last_seen_ip" => "1.2.3.4", "last_seen_user_agent" => "ie6", "created_at" => Time.now}
     user = Intercom::User.new(params)
-    user.to_hash.keys.sort.must_equal (params.keys + ['custom_attributes']).map(&:to_s).sort
+    custom_attributes = (params.keys + ['custom_attributes']).map(&:to_s).sort
+    user.to_hash.keys.sort.must_equal custom_attributes
     params.keys.each do |key|
       user.send(key).to_s.must_equal params[key].to_s
     end