Get universal conversation count

Author: dhiemstra

lib/intercom/service/count.rb

@@ -15,7 +15,9 @@ def for_app
       end
 
       def for_type(type:, count: nil)
-        find(type: type, count: count)
+        params = {type: type}
+        params[:count] = count if count
+        find(params)
       end
     end
   end

spec/unit/intercom/count_spec.rb

@@ -14,4 +14,10 @@
     counts = client.counts.for_type(type: 'user', count: 'segment')
     counts.user['segment'][4]["segment 1"].must_equal(1)
   end
+
+  it 'should not include count param when nil' do
+    client.expects(:get).with("/counts", {type: 'conversation'}).returns(test_segment_count)
+    counts = client.counts.for_type(type: 'conversation')
+    counts.user['segment'][4]["segment 1"].must_equal(1)
+  end
 end