Merge pull request #169 from intercom/BL/contactlist

Add the list resource to contact

Author: bobjflong

intercom.gemspec

@@ -23,6 +23,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake', '~> 10.3'
   spec.add_development_dependency 'mocha', '~> 1.0'
   spec.add_development_dependency "fakeweb", ["~> 1.3"]
+  spec.add_development_dependency "pry"
 
   spec.add_dependency 'json', '~> 1.8'
   spec.required_ruby_version = '>= 2.1.0'

lib/intercom/client_collection_proxy.rb

@@ -4,7 +4,7 @@
 module Intercom
   class ClientCollectionProxy
 
-    attr_reader :resource_name
+    attr_reader :resource_name, :finder_url, :resource_class
 
     def initialize(resource_name, finder_details: {}, client:)
       @resource_name = resource_name
@@ -41,8 +41,6 @@ def [](target_index)
 
     private
 
-    def resource_class; @resource_class; end
-
     def deserialize_response_hash(response_hash, block)
       top_level_type = response_hash.delete('type')
       if resource_name == 'subscriptions'

lib/intercom/service/contact.rb

@@ -8,6 +8,7 @@
 module Intercom
   module Service
     class Contact < BaseService
+      include ApiOperations::List
       include ApiOperations::Load
       include ApiOperations::Find
       include ApiOperations::FindAll

lib/intercom/service/tag.rb

@@ -23,15 +23,15 @@ def tag(params)
 
       def untag(params)
         params['tag_or_untag'] = 'untag'
-        users_or_companies.each do |user_or_company|
+        users_or_companies(params).each do |user_or_company|
           user_or_company[:untag] = true
         end
         create(params)
       end
 
       private
 
-      def users_or_companies
+      def users_or_companies(params)
         params[:users] || params[:companies]
       end
     end

spec/unit/intercom/contact_spec.rb

@@ -3,6 +3,13 @@
 describe "Intercom::Contact" do
   let (:client) { Intercom::Client.new(app_id: 'app_id',  api_key: 'api_key') }
 
+  it 'should be listable' do
+    proxy = client.contacts.all
+    proxy.resource_name.must_equal 'contacts'
+    proxy.finder_url.must_equal '/contacts'
+    proxy.resource_class.must_equal Intercom::Contact
+  end
+
   it 'should not throw ArgumentErrors when there are no parameters' do
     client.expects(:post)
     client.contacts.create