dont hoist to objects for to/from message params

Author: josler

lib/intercom/traits/api_resource.rb

@@ -67,7 +67,7 @@ def accessors_already_defined?(attribute)
       end
 
       def set_property(attribute, value)
-        if typed_value?(value) && !custom_attribute_field?(attribute)
+        if typed_value?(value) && !custom_attribute_field?(attribute) && !message_from_field?(attribute, value) && !message_to_field?(attribute, value)
           value_to_set = Intercom::Lib::TypedJsonDeserializer.new(value).deserialize
         elsif flat_store_attribute?(attribute)
           value_to_set = Intercom::Lib::FlatStore.new(value)
@@ -80,6 +80,14 @@ def set_property(attribute, value)
       def custom_attribute_field?(attribute)
         attribute == 'custom_attributes'
       end
+      
+      def message_from_field?(attribute, value)
+        attribute.to_s == 'from' && value.is_a?(Hash) && value['type']
+      end
+      
+      def message_to_field?(attribute, value)
+        attribute.to_s == 'to' && value.is_a?(Hash) && value['type']
+      end
 
       def typed_value?(value)
         value.is_a? Hash and !!value['type']

spec/unit/intercom/message_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe "Intercom::Message" do
+
+  let (:user) {Intercom::User.new("email" => "[email protected]", :user_id => "12345", :created_at => Time.now, :name => "Jim Bob")}
+
+  it 'creates an user message with symbol keys' do
+    Intercom.expects(:post).with('/messages', {'from' => { :type => 'user', :email => '[email protected]'}, 'body' => 'halp'}).returns(:status => 200)
+    Intercom::Message.create(:from => { :type => "user", :email => "[email protected]" }, :body => "halp")
+  end
+  
+  it "creates an user message with string keys" do
+    Intercom.expects(:post).with('/messages', {'from' => { 'type' => 'user', 'email' => '[email protected]'}, 'body' => 'halp'}).returns(:status => 200)
+    Intercom::Message.create('from' => { 'type' => "user", 'email' => "[email protected]" }, 'body' => "halp")
+  end
+  
+  it "creates a admin message" do
+    Intercom.expects(:post).with('/messages', {'from' => { 'type' => "admin", 'id' => "1234" }, 'to' => { 'type' => 'user', 'id' => '5678' }, 'body' => 'halp', 'message_type' => 'inapp'}).returns(:status => 200)
+    Intercom::Message.create('from' => { 'type' => "admin", 'id' => "1234" }, :to => { 'type' => 'user', 'id' => '5678' }, 'body' => "halp", 'message_type' => 'inapp')
+  end
+end