Skip to content

chore: clarify IDs and explain how to create a company #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: clarify IDs and explain how to create a company #611

wants to merge 1 commit into from

Conversation

Startouf
Copy link

it can be confusing which "user ID" we are talking about

  • Many users of this intercom library have their own users in their own database, and their "customer ID"
  • Intercom has its own unique user ID

Also, there was no example to create a company.

@Startouf
chore: clarify IDs and explain how to create a company
6e49b07 
Add create example
Add information regarding intercom IDs
@Startouf
Copy link
Author

I'm thinking of updating my PR to use "external id" to better match intercom documentation. I also found out one had to use intercom.find(external_id: user_in) and not (user_id: user_id)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@BeubeuCode BeubeuCode BeubeuCode approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Startouf @BeubeuCode