Skip to content

Commit ab4e041

Browse files
wip
1 parent b59cee6 commit ab4e041

File tree

3 files changed

+3
-14
lines changed

3 files changed

+3
-14
lines changed

packages/react-native/ReactCommon/react/renderer/components/view/ViewShadowNode.cpp

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
#include "ViewShadowNode.h"
99
#include <react/renderer/components/view/HostPlatformViewTraitsInitializer.h>
1010
#include <react/renderer/components/view/primitives.h>
11-
#include <react/renderer/core/LayoutContext.h>
1211
#include <react/renderer/graphics/BackgroundImage.h>
1312
#include <react/renderer/imagemanager/ImageManager.h>
1413
#include <react/renderer/imagemanager/primitives.h>
@@ -100,6 +99,7 @@ void ViewShadowNode::setImageManager(
10099
const std::shared_ptr<ImageManager>& imageManager) {
101100
ensureUnsealed();
102101
imageManager_ = imageManager;
102+
updateStateIfNeeded();
103103
}
104104

105105
void ViewShadowNode::updateStateIfNeeded() {
@@ -159,11 +159,4 @@ void ViewShadowNode::updateStateIfNeeded() {
159159
setStateData(std::move(state));
160160
}
161161

162-
#pragma mark - LayoutableShadowNode
163-
164-
void ViewShadowNode::layout(LayoutContext layoutContext) {
165-
updateStateIfNeeded();
166-
ConcreteViewShadowNode::layout(layoutContext);
167-
}
168-
169162
} // namespace facebook::react

packages/react-native/ReactCommon/react/renderer/components/view/ViewShadowNode.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,10 +41,6 @@ class ViewShadowNode final : public ConcreteViewShadowNode<ViewComponentName, Vi
4141

4242
void setImageManager(const std::shared_ptr<ImageManager> &imageManager);
4343

44-
#pragma mark - LayoutableShadowNode
45-
46-
void layout(LayoutContext layoutContext) override;
47-
4844
private:
4945
void initialize() noexcept;
5046
void updateStateIfNeeded();

packages/react-native/ReactCommon/react/renderer/components/view/ViewState.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#include <react/renderer/imagemanager/ImageRequest.h>
1212
#include <react/renderer/imagemanager/primitives.h>
1313

14-
#ifdef ANDROID
14+
#ifdef RN_SERIALIZABLE_STATE
1515
#include <folly/dynamic.h>
1616
#endif
1717

@@ -31,7 +31,7 @@ class ViewState final {
3131

3232
const std::vector<BackgroundImageURLRequest>& getBackgroundImageRequests() const;
3333

34-
#ifdef ANDROID
34+
#ifdef RN_SERIALIZABLE_STATE
3535
ViewState(const ViewState& previousState, folly::dynamic data) {}
3636

3737
folly::dynamic getDynamic() const {

0 commit comments

Comments
 (0)