feat(stripe): stripe integration is now optional, based on env var (#1976)

* feat(wallet-backend): conditionally integrate Stripe services based on environment variable

* feat(wallet-backend): update Stripe integration tests to always have use_stripe set on true

* chore(wallet-backend): format

Author: beniaminmunteanu

packages/wallet/backend/src/app.ts

@@ -156,7 +156,9 @@ export class App {
     const grantController = this.container.resolve('grantController')
     const accountController = this.container.resolve('accountController')
     const rafikiController = this.container.resolve('rafikiController')
-    const stripeController = this.container.resolve('stripeController')
+    const stripeController = env.USE_STRIPE
+      ? this.container.resolve('stripeController')
+      : undefined
     const gateHubController = this.container.resolve('gateHubController')
     const cardController = this.container.resolve('cardController')
 
@@ -174,11 +176,13 @@ export class App {
     app.use(helmet())
 
     // Stripe webhook signature validation requires raw body, parsing is done afterwards
-    app.post(
-      '/stripe-webhooks',
-      stripeController.webhookMiddleware,
-      stripeController.onWebHook
-    )
+    if (env.USE_STRIPE && stripeController) {
+      app.post(
+        '/stripe-webhooks',
+        stripeController.webhookMiddleware,
+        stripeController.onWebHook
+      )
+    }
 
     app.use(express.json())
     app.use(express.urlencoded({ extended: true, limit: '25mb' }))

packages/wallet/backend/src/config/env.ts

@@ -50,7 +50,8 @@ const envSchema = z.object({
   CARD_DATA_HREF: z.string().default('UPDATEME'),
   CARD_PIN_HREF: z.string().default('UPDATEME'),
   STRIPE_SECRET_KEY: z.string().default('STRIPE_SECRET_KEY'),
-  STRIPE_WEBHOOK_SECRET: z.string().default('STRIPE_WEBHOOK_SECRET')
+  STRIPE_WEBHOOK_SECRET: z.string().default('STRIPE_WEBHOOK_SECRET'),
+  USE_STRIPE: z.boolean().default(false)
 })
 
 export type Env = z.infer<typeof envSchema>

packages/wallet/backend/src/createContainer.ts

@@ -77,7 +77,7 @@ export interface Cradle {
   incomingPaymentService: IncomingPaymentService
   outgoingPaymentService: OutgoingPaymentService
   rafikiService: RafikiService
-  stripeService: StripeService
+  stripeService?: StripeService
   quoteService: QuoteService
   grantService: GrantService
   socketService: SocketService
@@ -89,7 +89,7 @@ export interface Cradle {
   incomingPaymentController: IncomingPaymentController
   outgoingPaymentController: OutgoingPaymentController
   rafikiController: RafikiController
-  stripeController: StripeController
+  stripeController?: StripeController
   quoteController: QuoteController
   grantController: GrantController
   walletAddressController: WalletAddressController
@@ -134,7 +134,12 @@ export async function createContainer(
     incomingPaymentService: asClass(IncomingPaymentService).singleton(),
     outgoingPaymentService: asClass(OutgoingPaymentService).singleton(),
     rafikiService: asClassSingletonWithLogger(RafikiService, logger),
-    stripeService: asClassSingletonWithLogger(StripeService, logger),
+    ...(env.USE_STRIPE
+      ? {
+          stripeService: asClassSingletonWithLogger(StripeService, logger),
+          stripeController: asClassSingletonWithLogger(StripeController, logger)
+        }
+      : {}),
     quoteService: asClass(QuoteService).singleton(),
     grantService: asClass(GrantService).singleton(),
     socketService: asClassSingletonWithLogger(SocketService, logger),
@@ -147,7 +152,6 @@ export async function createContainer(
     incomingPaymentController: asClass(IncomingPaymentController).singleton(),
     outgoingPaymentController: asClass(OutgoingPaymentController).singleton(),
     rafikiController: asClassSingletonWithLogger(RafikiController, logger),
-    stripeController: asClassSingletonWithLogger(StripeController, logger),
     quoteController: asClass(QuoteController).singleton(),
     grantController: asClass(GrantController).singleton(),
     walletAddressController: asClass(WalletAddressController).singleton(),

packages/wallet/backend/tests/stripe-integration/controller.test.ts

@@ -76,10 +76,13 @@ describe('Stripe Controller', () => {
   }
 
   beforeAll(async (): Promise<void> => {
-    bindings = await createContainer(env)
+    const testEnv = { ...env, USE_STRIPE: true }
+    bindings = await createContainer(testEnv)
     appContainer = await createApp(bindings)
     knex = appContainer.knex
-    stripeController = await bindings.resolve('stripeController')
+    stripeController = (await bindings.resolve(
+      'stripeController'
+    )) as StripeController
   })
 
   beforeEach(async (): Promise<void> => {

packages/wallet/backend/tests/stripe-integration/service.test.ts

@@ -52,10 +52,11 @@ describe('Stripe Service', (): void => {
   })
 
   beforeAll(async (): Promise<void> => {
-    bindings = await createContainer(env)
+    const testEnv = { ...env, USE_STRIPE: true }
+    bindings = await createContainer(testEnv)
     appContainer = await createApp(bindings)
     knex = appContainer.knex
-    stripeService = await bindings.resolve('stripeService')
+    stripeService = (await bindings.resolve('stripeService')) as StripeService
   })
 
   afterEach(async (): Promise<void> => {